Source/core/html/HTMLSelectElement.cpp - Issue 415343003: Option Groups with display: none should not show the children option elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.cpp

Issue 415343003: Option Groups with display: none should not show the children option elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed assert failure in linux dbg build Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLSelectElement.cpp

diff --git a/Source/core/html/HTMLSelectElement.cpp b/Source/core/html/HTMLSelectElement.cpp

index f6ecf4f839dcf973bdfd7731b2e537ae8f922f4f..acb51faef4f7a06fab12f3fd3a439479da511eab 100644

--- a/Source/core/html/HTMLSelectElement.cpp

+++ b/Source/core/html/HTMLSelectElement.cpp

@@ -36,6 +36,7 @@

#include "core/dom/Attribute.h"

#include "core/dom/ElementTraversal.h"

#include "core/dom/NodeListsNodeData.h"

+#include "core/dom/NodeRenderStyle.h"

#include "core/dom/NodeTraversal.h"

#include "core/events/GestureEvent.h"

#include "core/events/KeyboardEvent.h"

@@ -536,6 +537,8 @@ int HTMLSelectElement::nextValidIndex(int listIndex, SkipDirection direction, in

HTMLElement* element = listItems[listIndex];

if (!isHTMLOptionElement(*element))

continue;

+ if (toHTMLOptionElement(*element).isDisplayNone())

+ continue;

if (element->isDisabledFormControl())

continue;

if (!usesMenuList() && !element->renderer())

« no previous file with comments | « Source/core/html/HTMLOptionElement.cpp ('k') | Source/core/rendering/RenderMenuList.cpp » ('j') | no next file with comments »