Source/web/ExternalPopupMenu.h - Issue 415343003: Option Groups with display: none should not show the children option elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ExternalPopupMenu.h

Issue 415343003: Option Groups with display: none should not show the children option elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed assert failure in linux dbg build Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ExternalPopupMenu.h

diff --git a/Source/web/ExternalPopupMenu.h b/Source/web/ExternalPopupMenu.h

index 037a74aa087c67d6c6b86c3ad4f78e63446dfa1c..22089ef6bdb553a2cb8c3c2ec9ac8c8f6cfd48dc 100644

--- a/Source/web/ExternalPopupMenu.h

+++ b/Source/web/ExternalPopupMenu.h

@@ -77,6 +77,8 @@ private:

// Fills |info| with the popup menu information contained in the

// blink::PopupMenuClient associated with this ExternalPopupMenu.

void getPopupMenuInfo(WebPopupMenuInfo* info);

+ int toPopupMenuItemIndex(int index);

+ int toExternalPopupMenuItemIndex(int index);

blink::PopupMenuClient* m_popupMenuClient;

RefPtr<blink::FrameView> m_frameView;

« no previous file with comments | « Source/core/rendering/RenderMenuList.cpp ('k') | Source/web/ExternalPopupMenu.cpp » ('j') | no next file with comments »