Option Groups with display: none should not show the children option elements

Source/core/html/HTMLOptionElement.cpp

Index: Source/core/html/HTMLOptionElement.cpp
diff --git a/Source/core/html/HTMLOptionElement.cpp b/Source/core/html/HTMLOptionElement.cpp
index a02a889367e73b3afbc50809de3ccd44a1c21b21..bddd0e0e142b8fccb468a1663682a1701874c1d8 100644
--- a/Source/core/html/HTMLOptionElement.cpp
+++ b/Source/core/html/HTMLOptionElement.cpp
@@ -397,4 +397,18 @@ bool HTMLOptionElement::spatialNavigationFocused() const
     return select->spatialNavigationFocusedOption() == this;
 }
 
+bool HTMLOptionElement::isDisplayNone()
+{
+    RenderStyle* style = renderStyle() ? renderStyle() : computedStyle();
+    if (style && style->display() != NONE) {
+        HTMLElement* parent = Traversal<HTMLElement>::firstAncestor(*this);

[keishi, 2014/08/06 03:00:20]

I don't think we need to traverse.
Options that are displayed in a select element will always have select or
optgroup as the parent node.

This can be
if (parent is optgroup)
  return parent.isDisplayNone

Optgroup's parent should also be only select or optgroup.
So HTMLOptGroupElement::isDisplayNone should also be implemented the same way.

[spartha, 2014/08/06 06:23:02]

The spec says "In HTML 4, all OPTGROUP elements must be specified directly
within a SELECT element (i.e., groups may not be nested).", hence did not find
it necessary to add a similar method for <optgroup>

[spartha, 2014/08/06 08:13:31]

Avoided calling the Traversal
On 2014/08/06 03:00:20, keishi wrote:

+        ASSERT(parent);
+        if (isHTMLOptGroupElement(*parent)) {
+            RenderStyle* parentStyle = parent->renderStyle() ? parent->renderStyle() : parent->computedStyle();
+            return !parentStyle || parentStyle->display() == NONE;
+        }
+    }
+    return !style || style->display() == NONE;
+}
+
 } // namespace blink