Option Groups with display: none should not show the children option elements

Source/core/html/HTMLOptionElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2011 Motorola Mobility, Inc.  All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 379 matching lines @@
 }
 
 bool HTMLOptionElement::spatialNavigationFocused() const
 {
     HTMLSelectElement* select = ownerSelectElement();
     if (!select || !select->focused())
         return false;
     return select->spatialNavigationFocusedOption() == this;
 }
 
+bool HTMLOptionElement::isDisplayNone()
+{
+    RenderStyle* style = renderStyle() ? renderStyle() : computedStyle();
+    if (style && style->display() != NONE) {
+        HTMLElement* parent = Traversal<HTMLElement>::firstAncestor(*this);

[keishi, 2014/08/06 03:00:20]

I don't think we need to traverse.
Options that are displayed in a select element will always have select or
optgroup as the parent node.

This can be
if (parent is optgroup)
  return parent.isDisplayNone

Optgroup's parent should also be only select or optgroup.
So HTMLOptGroupElement::isDisplayNone should also be implemented the same way.

[spartha, 2014/08/06 06:23:02]

The spec says "In HTML 4, all OPTGROUP elements must be specified directly
within a SELECT element (i.e., groups may not be nested).", hence did not find
it necessary to add a similar method for <optgroup>

[spartha, 2014/08/06 08:13:31]

Avoided calling the Traversal
On 2014/08/06 03:00:20, keishi wrote:

+        ASSERT(parent);
+        if (isHTMLOptGroupElement(*parent)) {
+            RenderStyle* parentStyle = parent->renderStyle() ? parent->renderStyle() : parent->computedStyle();
+            return !parentStyle || parentStyle->display() == NONE;
+        }
+    }
+    return !style || style->display() == NONE;
+}
+
 } // namespace blink