Source/core/html/HTMLOptionElement.h - Issue 415343003: Option Groups with display: none should not show the children option elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLOptionElement.h

Issue 415343003: Option Groups with display: none should not show the children option elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/select/popup-with-display-none-optgroup.html ('K') | « LayoutTests/fast/forms/select/popup-with-display-none-optgroup-expected.txt ('k') | Source/core/html/HTMLOptionElement.cpp » ('j') | Source/core/html/HTMLOptionElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLOptionElement.h

diff --git a/Source/core/html/HTMLOptionElement.h b/Source/core/html/HTMLOptionElement.h

index 1ec8dd5f57492cf86ea62c2e62e4b8056a65dea6..9c114d1393aeacafb4206be9fe7d9f0daa67db8f 100644

--- a/Source/core/html/HTMLOptionElement.h

+++ b/Source/core/html/HTMLOptionElement.h

@@ -67,6 +67,7 @@ public:

HTMLFormElement* form() const;

bool spatialNavigationFocused() const;

+ bool isDisplayNone();

private:

explicit HTMLOptionElement(Document&);

virtual ~HTMLOptionElement();