Issue 414583002: VideoRenderer: Fires all pending callbacks in dtor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 414583002: VideoRenderer: Fires all pending callbacks in dtor. (Closed)

Created:
6 years, 5 months ago by xhwang

Modified:
6 years, 5 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

VideoRenderer: Fires all pending callbacks in dtor. This make VideoRenderer consistent with the rest of the media pipeline. BUG=349211 TEST=All existing tests pass. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284898

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -12 lines)			Patch
M	media/base/video_renderer.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	media/filters/video_renderer_impl.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	media/filters/video_renderer_impl_unittest.cc	View	3 chunks	+2 lines, -9 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/414583002/1

6 years, 5 months ago (2014-07-23 05:11:18 UTC) #4

Message was sent while issue was closed.

Change committed as 284898