media/filters/video_renderer_impl.cc - Issue 414583002: VideoRenderer: Fires all pending callbacks in dtor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/video_renderer_impl.cc

Issue 414583002: VideoRenderer: Fires all pending callbacks in dtor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/video_renderer_impl.cc

diff --git a/media/filters/video_renderer_impl.cc b/media/filters/video_renderer_impl.cc

index f65cf2f2aed9e7a3ed6579c32b1eeaa1eece68bd..f315b717053521a2c113e75c1dc179900563f067 100644

--- a/media/filters/video_renderer_impl.cc

+++ b/media/filters/video_renderer_impl.cc

@@ -57,6 +57,12 @@ VideoRendererImpl::~VideoRendererImpl() {

if (!thread_.is_null())

base::PlatformThread::Join(thread_);

+ if (!init_cb_.is_null())

+ base::ResetAndReturn(&init_cb_).Run(PIPELINE_ERROR_ABORT);

+ if (!flush_cb_.is_null())

+ base::ResetAndReturn(&flush_cb_).Run();

}

void VideoRendererImpl::Flush(const base::Closure& callback) {

« no previous file with comments | « media/base/video_renderer.h ('k') | media/filters/video_renderer_impl_unittest.cc » ('j') | no next file with comments »