media/base/video_renderer.h - Issue 414583002: VideoRenderer: Fires all pending callbacks in dtor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/video_renderer.h

Issue 414583002: VideoRenderer: Fires all pending callbacks in dtor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/video_renderer.h

diff --git a/media/base/video_renderer.h b/media/base/video_renderer.h

index ff675b9645dc84103824962b4633cddd269f11f8..591e5e050a1e64be2e7acda78ab6a6c9c445835f 100644

--- a/media/base/video_renderer.h

+++ b/media/base/video_renderer.h

@@ -28,9 +28,7 @@ class MEDIA_EXPORT VideoRenderer {

VideoRenderer();

- // Stops all operations and drops all pending callbacks.

- // TODO(xhwang): Fires all pending callbacks to be consistent with the rest of

- // media pipeline.

+ // Stops all operations and fires all pending callbacks.

virtual ~VideoRenderer();

// Initializes a VideoRenderer with |stream|, executing |init_cb| upon

« no previous file with comments | « no previous file | media/filters/video_renderer_impl.cc » ('j') | no next file with comments »