Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 414303006: Fix use-after-free related to RenderFullScreen (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
Reviewers:
falken, esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Fix use-after-free related to RenderFullScreen BUG=357452 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179436

Patch Set 1 #

Patch Set 2 : new deal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -3 lines) Patch
A LayoutTests/fullscreen/full-screen-contentEditable-crash.html View 1 chunk +35 lines, -0 lines 0 comments Download
A LayoutTests/fullscreen/full-screen-contentEditable-crash-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderFullScreen.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
philipj_slow
PTAL. I went for a very localized fix in case this needs to be backported, ...
6 years, 4 months ago (2014-07-25 23:13:47 UTC) #1
esprehn
What calls destroy() now, it looks like you're just leaking the renderers.
6 years, 4 months ago (2014-07-25 23:35:37 UTC) #2
philipj_slow
Uh, right, I explained that away as "whatever unwrapRenderer() does" even though I've changed what ...
6 years, 4 months ago (2014-07-26 08:08:57 UTC) #3
philipj_slow
Ping falken and esprehn.
6 years, 4 months ago (2014-07-29 14:54:36 UTC) #4
falken
Ack, sorry I missed this. I intend to look today or tomorrow. +esprehn as well ...
6 years, 4 months ago (2014-07-31 04:26:35 UTC) #5
esprehn
lgtm, thanks for fixing this!
6 years, 4 months ago (2014-08-01 14:00:42 UTC) #6
philipj_slow
Matt, wanna have a look before I land this?
6 years, 4 months ago (2014-08-01 15:09:05 UTC) #7
falken
On 2014/08/01 15:09:05, philipj wrote: > Matt, wanna have a look before I land this? ...
6 years, 4 months ago (2014-08-02 04:06:57 UTC) #8
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-02 04:30:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/414303006/20001
6 years, 4 months ago (2014-08-02 04:30:46 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 04:33:43 UTC) #11
Message was sent while issue was closed.
Change committed as 179436

Powered by Google App Engine
This is Rietveld 408576698