Source/core/dom/FullscreenElementStack.cpp - Issue 414303006: Fix use-after-free related to RenderFullScreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/FullscreenElementStack.cpp

Issue 414303006: Fix use-after-free related to RenderFullScreen (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: new deal Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/FullscreenElementStack.cpp

diff --git a/Source/core/dom/FullscreenElementStack.cpp b/Source/core/dom/FullscreenElementStack.cpp

index c5fc482260612002eba1cabbc9cfbfc5bb253c7c..adde493d559368f461fe6c102909fc8af48ea9fc 100644

--- a/Source/core/dom/FullscreenElementStack.cpp

+++ b/Source/core/dom/FullscreenElementStack.cpp

@@ -127,7 +127,7 @@ void FullscreenElementStack::documentWasDetached()

m_eventQueue.clear();

if (m_fullScreenRenderer)

- setFullScreenRenderer(0);

+ m_fullScreenRenderer->destroy();

#if ENABLE(OILPAN)

m_fullScreenElement = nullptr;

@@ -475,7 +475,7 @@ void FullscreenElementStack::setFullScreenRenderer(RenderFullScreen* renderer)

}

if (m_fullScreenRenderer)

- m_fullScreenRenderer->destroy();

+ m_fullScreenRenderer->unwrapRenderer();

ASSERT(!m_fullScreenRenderer);

m_fullScreenRenderer = renderer;