Source/core/rendering/RenderFullScreen.cpp - Issue 414303006: Fix use-after-free related to RenderFullScreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderFullScreen.cpp

Issue 414303006: Fix use-after-free related to RenderFullScreen (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: new deal Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderFullScreen.cpp

diff --git a/Source/core/rendering/RenderFullScreen.cpp b/Source/core/rendering/RenderFullScreen.cpp

index 484e9c38be8d8082b7dff63d339a5bf0418f58e3..58c2b5c9ac9cd9eb8162002898ff191b37b6c384 100644

--- a/Source/core/rendering/RenderFullScreen.cpp

+++ b/Source/core/rendering/RenderFullScreen.cpp

@@ -169,7 +169,7 @@ void RenderFullScreen::unwrapRenderer()

if (placeholder())

placeholder()->remove();

remove();

- FullscreenElementStack::from(document()).setFullScreenRenderer(0);

+ destroy();

}

void RenderFullScreen::setPlaceholder(RenderBlock* placeholder)

« no previous file with comments | « Source/core/dom/FullscreenElementStack.cpp ('k') | no next file » | no next file with comments »