Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 41423002: Devirtualize PageConsole and MHTMLArchive destructors (Closed)

Created:
7 years, 1 month ago by Inactive
Modified:
7 years, 1 month ago
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Devirtualize PageConsole and MHTMLArchive destructors Devirtualize PageConsole and MHTMLArchive destructors as these classes are never subclassed nor do they have any virtual function. This avoids creating unnecessary vtables. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160517

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M Source/core/loader/archive/MHTMLArchive.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PageConsole.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/PageConsole.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Inactive
7 years, 1 month ago (2013-10-24 20:58:30 UTC) #1
abarth-chromium
lgtm
7 years, 1 month ago (2013-10-24 21:47:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/41423002/1
7 years, 1 month ago (2013-10-24 21:48:19 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=13694
7 years, 1 month ago (2013-10-24 22:54:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/41423002/1
7 years, 1 month ago (2013-10-24 23:01:25 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=13727
7 years, 1 month ago (2013-10-25 00:35:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/41423002/1
7 years, 1 month ago (2013-10-25 00:39:28 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-10-25 02:12:07 UTC) #8
Message was sent while issue was closed. 
Change committed as 160517

Powered by Google App Engine
This is Rietveld 408576698