Source/core/page/PageConsole.h - Issue 41423002: Devirtualize PageConsole and MHTMLArchive destructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/PageConsole.h

Issue 41423002: Devirtualize PageConsole and MHTMLArchive destructors (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/PageConsole.h

diff --git a/Source/core/page/PageConsole.h b/Source/core/page/PageConsole.h

index 8f92d695e3e4998f1e533f8e98dd2e9dbc018197..e0f96db7c581af5460e15452a11ef97491f1e9ad 100644

--- a/Source/core/page/PageConsole.h

+++ b/Source/core/page/PageConsole.h

@@ -42,7 +42,6 @@ class Page;

class PageConsole {

public:

static PassOwnPtr<PageConsole> create(Page* page) { return adoptPtr(new PageConsole(page)); }

- virtual ~PageConsole();

void addMessage(MessageSource, MessageLevel, const String& message);

void addMessage(MessageSource, MessageLevel, const String& message, const String& sourceURL, unsigned lineNumber, unsigned columnNumber = 0, PassRefPtr<ScriptCallStack> = 0, ScriptState* = 0, unsigned long requestIdentifier = 0);

« no previous file with comments | « Source/core/loader/archive/MHTMLArchive.h ('k') | Source/core/page/PageConsole.cpp » ('j') | no next file with comments »