Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: Source/core/page/PageConsole.h

Issue 41423002: Devirtualize PageConsole and MHTMLArchive destructors (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/loader/archive/MHTMLArchive.h ('k') | Source/core/page/PageConsole.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 24 matching lines...) Expand all
35 #include "wtf/Forward.h" 35 #include "wtf/Forward.h"
36 #include "wtf/PassOwnPtr.h" 36 #include "wtf/PassOwnPtr.h"
37 37
38 namespace WebCore { 38 namespace WebCore {
39 39
40 class Page; 40 class Page;
41 41
42 class PageConsole { 42 class PageConsole {
43 public: 43 public:
44 static PassOwnPtr<PageConsole> create(Page* page) { return adoptPtr(new Page Console(page)); } 44 static PassOwnPtr<PageConsole> create(Page* page) { return adoptPtr(new Page Console(page)); }
45 virtual ~PageConsole();
46 45
47 void addMessage(MessageSource, MessageLevel, const String& message); 46 void addMessage(MessageSource, MessageLevel, const String& message);
48 void addMessage(MessageSource, MessageLevel, const String& message, const St ring& sourceURL, unsigned lineNumber, unsigned columnNumber = 0, PassRefPtr<Scri ptCallStack> = 0, ScriptState* = 0, unsigned long requestIdentifier = 0); 47 void addMessage(MessageSource, MessageLevel, const String& message, const St ring& sourceURL, unsigned lineNumber, unsigned columnNumber = 0, PassRefPtr<Scri ptCallStack> = 0, ScriptState* = 0, unsigned long requestIdentifier = 0);
49 void addMessage(MessageSource, MessageLevel, const String& message, PassRefP tr<ScriptCallStack>); 48 void addMessage(MessageSource, MessageLevel, const String& message, PassRefP tr<ScriptCallStack>);
50 static String formatStackTraceString(const String& originalMessage, PassRefP tr<ScriptCallStack>); 49 static String formatStackTraceString(const String& originalMessage, PassRefP tr<ScriptCallStack>);
51 50
52 static void mute(); 51 static void mute();
53 static void unmute(); 52 static void unmute();
54 53
55 private: 54 private:
56 explicit PageConsole(Page*); 55 explicit PageConsole(Page*);
57 56
58 Page* m_page; 57 Page* m_page;
59 }; 58 };
60 59
61 } // namespace WebCore 60 } // namespace WebCore
62 61
63 #endif // PageConsole_h 62 #endif // PageConsole_h
OLDNEW
« no previous file with comments | « Source/core/loader/archive/MHTMLArchive.h ('k') | Source/core/page/PageConsole.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698