Issue 412833002: Ensure JavaScript equality when serviceWorker.register resolves to an existing worker [2/3]

Issue 412833002: Ensure JavaScript equality when serviceWorker.register resolves to an existing worker [2/3] (Closed)

Created:
6 years, 5 months ago by falken

Modified:
6 years, 5 months ago

Reviewers:
dominicc (has gone to gerrit), nhiroki

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Ensure JavaScript equality when serviceWorker.register resolves to an existing worker [2/3] Three-sided patch: [1] Blink: https://codereview.chromium.org/409403002 [2] Chromium: reuse a ServiceWorkerHandle [3] Blink: https://codereview.chromium.org/411863003 BUG=395928 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285570

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comment #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -6 lines)			Patch
M	content/browser/service_worker/service_worker_dispatcher_host.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/service_worker/service_worker_dispatcher_host.cc	View		2 chunks	+26 lines, -5 lines	0 comments	Download
M	content/browser/service_worker/service_worker_handle.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

nhiroki

lgtm https://codereview.chromium.org/412833002/diff/1/content/browser/service_worker/service_worker_handle.h File content/browser/service_worker/service_worker_handle.h (right): https://codereview.chromium.org/412833002/diff/1/content/browser/service_worker/service_worker_handle.h#newcode73 content/browser/service_worker/service_worker_handle.h:73: int thread_id() const { return thread_id_; } nit: ...

6 years, 5 months ago (2014-07-24 02:13:54 UTC) #2

falken

https://codereview.chromium.org/412833002/diff/1/content/browser/service_worker/service_worker_handle.h File content/browser/service_worker/service_worker_handle.h (right): https://codereview.chromium.org/412833002/diff/1/content/browser/service_worker/service_worker_handle.h#newcode73 content/browser/service_worker/service_worker_handle.h:73: int thread_id() const { return thread_id_; } On 2014/07/24 ...

6 years, 5 months ago (2014-07-24 02:24:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/412833002/40001

6 years, 5 months ago (2014-07-25 10:34:31 UTC) #5

Message was sent while issue was closed.

Change committed as 285570

Expand Messages | Collapse Messages