Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1409)

Issue 411863003: Ensure JavaScript equality when serviceWorker.register resolves to an existing worker [3/3] (Closed)

Created:
6 years, 5 months ago by falken
Modified:
6 years, 5 months ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Project:
blink
Visibility:
Public.

Description

Ensure JavaScript equality when serviceWorker.register resolves to an existing worker [3/3] Three-sided patch: [1] Blink: https://codereview.chromium.org/409403002 [2] Chromium: https://codereview.chromium.org/412833002/ [3] Blink: test (THIS PATCH) BUG=395928 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178938

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
A LayoutTests/http/tests/serviceworker/multiple-register.html View 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
falken
6 years, 5 months ago (2014-07-23 11:09:47 UTC) #1
nhiroki
lgtm
6 years, 5 months ago (2014-07-24 02:15:02 UTC) #2
falken
The CQ bit was checked by falken@chromium.org
6 years, 5 months ago (2014-07-25 12:48:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/411863003/1
6 years, 5 months ago (2014-07-25 12:48:28 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-25 13:49:39 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 14:57:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/18961)
6 years, 5 months ago (2014-07-25 14:57:16 UTC) #7
falken
The CQ bit was checked by falken@chromium.org
6 years, 5 months ago (2014-07-25 15:21:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/411863003/1
6 years, 5 months ago (2014-07-25 15:22:11 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 15:55:35 UTC) #10
Message was sent while issue was closed.
Change committed as 178938

Powered by Google App Engine
This is Rietveld 408576698