Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 409403002: Ensure JavaScript equality when serviceWorker.register resolves to an existing worker [1/3] (Closed)

Created:
6 years, 5 months ago by falken
Modified:
6 years, 5 months ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Project:
blink
Visibility:
Public.

Description

Ensure JavaScript equality when serviceWorker.register resolves to an existing worker [1/3] If there's an existing registration for the scope and script url, serviceWorker.register resolves to the active worker for that registration. This patch modifies the dispatcher to reuse an existing ServiceWorkerHandle, so service workers that are the same have JavaScript equality. Three-sided patch: [1] Blink: ServiceWorker::from can be called from CallbackPromiseAdapter for a SW that was already registered and reached the proxy "ready" state [2] Chromium: https://codereview.chromium.org/412833002/ [3] Blink: https://codereview.chromium.org/411863003 BUG=395928 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178810

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/modules/serviceworkers/ServiceWorker.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
falken
PTAL. Since register is changing, this is not so important, but it helps for writing ...
6 years, 5 months ago (2014-07-23 11:09:14 UTC) #1
nhiroki
lgtm
6 years, 5 months ago (2014-07-24 02:08:46 UTC) #2
falken
The CQ bit was checked by falken@chromium.org
6 years, 5 months ago (2014-07-24 02:17:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/409403002/1
6 years, 5 months ago (2014-07-24 02:17:50 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-24 03:22:35 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 04:29:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/18629)
6 years, 5 months ago (2014-07-24 04:29:53 UTC) #7
falken
The CQ bit was checked by falken@chromium.org
6 years, 5 months ago (2014-07-24 04:47:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/409403002/1
6 years, 5 months ago (2014-07-24 04:47:18 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-24 05:06:51 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 05:18:28 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/18645)
6 years, 5 months ago (2014-07-24 05:18:29 UTC) #12
falken
The CQ bit was checked by falken@chromium.org
6 years, 5 months ago (2014-07-24 05:25:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/409403002/1
6 years, 5 months ago (2014-07-24 05:26:52 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 06:20:28 UTC) #15
Message was sent while issue was closed.
Change committed as 178810

Powered by Google App Engine
This is Rietveld 408576698