Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1541)

Unified Diff: Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 412183002: DevTools: Introduce createRawLocationByConsoleCallFrame to linkify links in Network popover correct… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/Source/devtools/front_end/console/ConsoleViewMessage.js b/Source/devtools/front_end/console/ConsoleViewMessage.js
index dbe508274e63e5041259692e8467220e2e98e45e..b699590c60ebf87384d8e2e1e87bf512a26f67e0 100644
--- a/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -279,10 +279,7 @@ WebInspector.ConsoleViewMessage.prototype = {
var target = this._target();
if (!this._linkifier || !target)
return null;
- // FIXME(62725): stack trace line/column numbers are one-based.
- var lineNumber = callFrame.lineNumber ? callFrame.lineNumber - 1 : 0;
- var columnNumber = callFrame.columnNumber ? callFrame.columnNumber - 1 : 0;
- var rawLocation = new WebInspector.DebuggerModel.Location(target, callFrame.scriptId, lineNumber, columnNumber);
+ var rawLocation = this._target().debuggerModel.createRawLocationByConsoleCallFrame(callFrame);
return this._linkifier.linkifyRawLocation(rawLocation, "console-message-url");
},
« no previous file with comments | « no previous file | Source/devtools/front_end/network/NetworkPanel.js » ('j') | Source/devtools/front_end/network/NetworkPanel.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698