Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1976)

Unified Diff: Source/devtools/front_end/sdk/DebuggerModel.js

Issue 412183002: DevTools: Introduce createRawLocationByConsoleCallFrame to linkify links in Network popover correct… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sdk/DebuggerModel.js
diff --git a/Source/devtools/front_end/sdk/DebuggerModel.js b/Source/devtools/front_end/sdk/DebuggerModel.js
index b66a938b5aaa424c8bb32e4e10a96f33f2725e68..e5027c8842f27472b51bd1623910903bac25e6f3 100644
--- a/Source/devtools/front_end/sdk/DebuggerModel.js
+++ b/Source/devtools/front_end/sdk/DebuggerModel.js
@@ -577,6 +577,18 @@ WebInspector.DebuggerModel.prototype = {
},
/**
+ * @param {!ConsoleAgent.CallFrame} callFrame
+ * @return {!WebInspector.DebuggerModel.Location}
+ */
+ createRawLocationByConsoleCallFrame: function(callFrame)
+ {
+ // FIXME(62725): console stack trace line/column numbers are one-based.
+ var lineNumber = callFrame.lineNumber ? callFrame.lineNumber - 1 : 0;
+ var columnNumber = callFrame.columnNumber ? callFrame.columnNumber - 1 : 0;
+ return new WebInspector.DebuggerModel.Location(this.target(), callFrame.scriptId, lineNumber, columnNumber);
+ },
+
+ /**
* @return {boolean}
*/
isPaused: function()

Powered by Google App Engine
This is Rietveld 408576698