Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 41213003: Hook in rough distance field support for fonts (Closed)

Created:
7 years, 1 month ago by jvanverth1
Modified:
7 years, 1 month ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Hook in rough distance field support for fonts R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=12229

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add new edtaa third_party library. Use gradiant-based EDTAA to compute distance field. #

Patch Set 3 : Port over fix for alpha-blended paint color (may not be needed). #

Total comments: 6

Patch Set 4 : Hide most of distance field font code behind a GYP conditional. #

Patch Set 5 : Minor fixes for GrDistanceFieldTextContext. #

Total comments: 48

Patch Set 6 : Fix nits; remove ScaleText GM; put edtaa functions in namespace. #

Patch Set 7 : Hide core level distance field font code behind #define #

Patch Set 8 : Replace magic number 32 with constant; fix comment in shader; fix Linux compiler error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2914 lines, -1941 lines) Patch
M gyp/common_conditions.gypi View 1 2 3 4 5 6 1 chunk +11 lines, -0 lines 0 comments Download
M gyp/common_variables.gypi View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
A gyp/edtaa.gyp View 1 2 3 1 chunk +38 lines, -0 lines 0 comments Download
M gyp/gpu.gyp View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download
A + include/gpu/GrDistanceFieldTextContext.h View 1 2 3 4 5 6 7 1 chunk +9 lines, -9 lines 0 comments Download
M src/core/SkDraw.cpp View 1 2 3 4 5 6 7 4 chunks +70 lines, -1 line 0 comments Download
M src/core/SkDrawProcs.h View 1 2 3 4 5 6 7 1 chunk +16 lines, -0 lines 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
A + src/gpu/GrDistanceFieldTextContext.cpp View 1 2 3 4 5 6 7 10 chunks +45 lines, -31 lines 0 comments Download
M src/gpu/GrTextStrike.h View 1 2 3 4 5 6 2 chunks +9 lines, -2 lines 0 comments Download
M src/gpu/GrTextStrike.cpp View 1 2 3 4 5 6 7 6 chunks +130 lines, -10 lines 0 comments Download
M src/gpu/GrTextStrike_impl.h View 1 2 3 4 5 6 2 chunks +7 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 4 5 6 7 1 chunk +1877 lines, -1860 lines 0 comments Download
A + src/gpu/effects/GrDistanceFieldTextureEffect.h View 1 2 3 4 5 1 chunk +10 lines, -9 lines 0 comments Download
A + src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 1 2 3 4 5 6 7 7 chunks +29 lines, -18 lines 0 comments Download
A third_party/edtaa/LICENSE View 1 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/edtaa/edtaa3.h View 1 2 3 4 5 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/edtaa/edtaa3func.cpp View 1 2 3 4 5 1 chunk +586 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jvanverth1
This is a first pass at getting distance fields working for fonts, at least on ...
7 years, 1 month ago (2013-10-24 19:36:02 UTC) #1
bungeman-skia
Commenting on the one thing I know about. https://codereview.chromium.org/41213003/diff/1/src/core/SkDraw.cpp File src/core/SkDraw.cpp (right): https://codereview.chromium.org/41213003/diff/1/src/core/SkDraw.cpp#newcode1689 src/core/SkDraw.cpp:1689: paintCopy.setTextSize(32); ...
7 years, 1 month ago (2013-10-24 19:50:48 UTC) #2
jvanverth1
On 2013/10/24 19:50:48, bungeman1 wrote: > Commenting on the one thing I know about. > ...
7 years, 1 month ago (2013-11-04 20:23:31 UTC) #3
bsalomon
https://codereview.chromium.org/41213003/diff/270001/gyp/gpu.gyp File gyp/gpu.gyp (right): https://codereview.chromium.org/41213003/diff/270001/gyp/gpu.gyp#newcode86 gyp/gpu.gyp:86: 'edtaa.gyp:*', Can we make this dependency require a gyp/compile ...
7 years, 1 month ago (2013-11-04 20:34:52 UTC) #4
jvanverth1
https://codereview.chromium.org/41213003/diff/270001/gyp/gpu.gyp File gyp/gpu.gyp (right): https://codereview.chromium.org/41213003/diff/270001/gyp/gpu.gyp#newcode86 gyp/gpu.gyp:86: 'edtaa.gyp:*', On 2013/11/04 20:34:53, bsalomon wrote: > Can we ...
7 years, 1 month ago (2013-11-05 14:59:11 UTC) #5
bsalomon
lgtm if reed@ is good with the SkDraw changes. Some minor stuff noted. https://codereview.chromium.org/41213003/diff/340001/src/gpu/GrTextStrike.cpp File ...
7 years, 1 month ago (2013-11-05 15:28:51 UTC) #6
robertphillips
https://codereview.chromium.org/41213003/diff/340001/gm/scaletext.cpp File gm/scaletext.cpp (right): https://codereview.chromium.org/41213003/diff/340001/gm/scaletext.cpp#newcode1 gm/scaletext.cpp:1: /* Update this? https://codereview.chromium.org/41213003/diff/340001/gm/scaletext.cpp#newcode11 gm/scaletext.cpp:11: // raison d'etre https://codereview.chromium.org/41213003/diff/340001/gm/scaletext.cpp#newcode50 ...
7 years, 1 month ago (2013-11-05 15:30:25 UTC) #7
jvanverth1
https://codereview.chromium.org/41213003/diff/340001/gm/scaletext.cpp File gm/scaletext.cpp (right): https://codereview.chromium.org/41213003/diff/340001/gm/scaletext.cpp#newcode1 gm/scaletext.cpp:1: /* On 2013/11/05 15:30:26, robertphillips wrote: > Update this? ...
7 years, 1 month ago (2013-11-05 17:09:21 UTC) #8
jvanverth1
7 years, 1 month ago (2013-11-11 20:54:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #8 manually as r12229 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698