Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 411693003: Validate the assembly code that Subzero generates in unit tests. (Closed)

Created:
6 years, 5 months ago by wala
Modified:
6 years, 5 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Validate the assembly code that Subzero generates in unit tests. Add RUN lines to applicable lit tests to pipe the output of Subzero (in -Om1 and/or -O2 mode) to llvm-mc for validation. Note that the following unit tests fail the validation: * callindirect.pnacl.ll * mangle.ll * nacl-other-intrinsics.ll BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=927cc17

Patch Set 1 #

Patch Set 2 : Comment out failing RUN lines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M tests_lit/llvm2ice_tests/64bit.pnacl.ll View 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/alloc.ll View 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/bitcast.ll View 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/callindirect.pnacl.ll View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/cmp-opt.ll View 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/convert.ll View 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/div_legalization.ll View 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/fp.pnacl.ll View 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/fpconst.pnacl.ll View 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/globalinit.pnacl.ll View 1 chunk +1 line, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/mangle.ll View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-atomic-fence-all.ll View 1 chunk +1 line, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-atomic-intrinsics.ll View 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/select-opt.ll View 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/shift.ll View 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/simple-loop.ll View 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/undef.ll View 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/unreachable.ll View 1 chunk +1 line, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-arg.ll View 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-arith.ll View 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-bitcast.ll View 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-cast.ll View 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-ops.ll View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
wala
6 years, 5 months ago (2014-07-22 21:14:09 UTC) #1
Jim Stichnoth
LGTM, except that we don't want to add new tests that fail. Better to add ...
6 years, 5 months ago (2014-07-22 22:00:05 UTC) #2
wala
6 years, 5 months ago (2014-07-22 22:03:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r927cc17 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698