Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 411633003: Don't use clang by default when cross building for ARM/linux. (Closed)

Created:
6 years, 5 months ago by Sam Clegg
Modified:
6 years, 3 months ago
CC:
chromium-reviews, nodir
Project:
chromium
Visibility:
Public.

Description

Don't use clang by default when cross building for ARM/linux. Currently our cross-builders for ARM use the ubuntu gcc cross compiler (on Precise this is gcc 4.6). This is a temporary fix since 4.6 support is on the way out. The longer term fix will be to switch to clang for cross builds. BUG=395832 TEST=arm_linux_cross_compile bot

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M build/common.gypi View 1 2 2 chunks +13 lines, -1 line 3 comments Download

Messages

Total messages: 7 (0 generated)
Sam Clegg
The current bot failure is due to a different issue: https://codereview.chromium.org/401243002/
6 years, 5 months ago (2014-07-22 22:18:43 UTC) #1
Mark Seaborn
[+bradnelson and nodir] https://codereview.chromium.org/411633003/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/411633003/diff/20001/build/common.gypi#newcode1783 build/common.gypi:1783: ['OS=="linux" and target_arch!="mipsel" and target_arch!="arm"', { ...
6 years, 5 months ago (2014-07-22 22:23:31 UTC) #2
Nico
This won't help. Trunk doesn't compile with 4.6.
6 years, 5 months ago (2014-07-22 22:24:29 UTC) #3
Nico
https://codereview.chromium.org/411633003/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/411633003/diff/20001/build/common.gypi#newcode1783 build/common.gypi:1783: ['OS=="linux" and target_arch!="mipsel" and target_arch!="arm"', { On 2014/07/22 22:23:31, ...
6 years, 5 months ago (2014-07-22 22:25:01 UTC) #4
Nico
https://codereview.chromium.org/411633003/diff/40001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/411633003/diff/40001/build/common.gypi#newcode4277 build/common.gypi:4277: '-std=gnu++0x', Oh, I missed this. I really don't want ...
6 years, 5 months ago (2014-07-22 22:26:26 UTC) #5
Sam Clegg
https://codereview.chromium.org/411633003/diff/40001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/411633003/diff/40001/build/common.gypi#newcode4277 build/common.gypi:4277: '-std=gnu++0x', On 2014/07/22 22:26:26, Nico (away) wrote: > Oh, ...
6 years, 5 months ago (2014-07-23 00:35:50 UTC) #6
Nico
6 years, 5 months ago (2014-07-23 00:40:10 UTC) #7
https://codereview.chromium.org/411633003/diff/40001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/411633003/diff/40001/build/common.gypi#newcod...
build/common.gypi:4277: '-std=gnu++0x',
On 2014/07/23 00:35:50, Sam Clegg wrote:
> On 2014/07/22 22:26:26, Nico (away) wrote:
> > Oh, I missed this. I really don't want to have a bot that uses 4.6 and
> > std=gnu++0x. There are many known compiler bugs with c++11 and 4.6, which is
> why
> > we're not supporting this configuration in the first place.
> > 
> > The way forward for this bot is either clang or a qemu with gcc 4.8 and
> whatnot
> > as suggested by jam.
> 
> 
> OK.  I'll keep pushing forward with clang.
> 
> Should we error out if gccversion>0 && gccversion<48 than?

Yes. That's blocked on someone (likely me :-) ) to figure out the "a better fix"
thing described at https://codereview.chromium.org/379693003/ , as under certain
conditions gcc_version is not 0 even with clang at the moment.

Powered by Google App Engine
This is Rietveld 408576698