Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 379693003: Hotfix to make clang-by-default work with gcc 4.8 (Closed)

Created:
6 years, 5 months ago by Nico
Modified:
6 years, 5 months ago
Reviewers:
Lei Zhang, tonikitoo_
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Hotfix to make clang-by-default work with gcc 4.8 A better fix is to set clang further up, so that gcc_version is set to 0 when clang is on automatically ( https://codereview.chromium.org/384633005 ). This is however blocked on nacl also using the "clang" symbol, so that needs to be fixed first ( https://codereview.chromium.org/384793002 ). To make the build go for people in the meantime, land this hack. I'll revert it once the nacl change has landed in nacl and then rolled into chromium, and the better fix has landed. BUG=360311 TBR=thestig@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M build/common.gypi View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
6 years, 5 months ago (2014-07-10 17:26:39 UTC) #1
tonikitoo_
On 2014/07/10 17:26:39, Nico (away) wrote: informal lgtm
6 years, 5 months ago (2014-07-10 17:32:54 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 5 months ago (2014-07-10 17:40:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/379693003/1
6 years, 5 months ago (2014-07-10 17:42:14 UTC) #4
Nico
The CQ bit was unchecked by thakis@chromium.org
6 years, 5 months ago (2014-07-10 17:58:17 UTC) #5
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 5 months ago (2014-07-10 17:58:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/379693003/1
6 years, 5 months ago (2014-07-10 18:00:04 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 18:02:04 UTC) #8
Message was sent while issue was closed.
Change committed as 282377

Powered by Google App Engine
This is Rietveld 408576698