Issue 41133002: Remove virtual destructors for CustomElementDefinition and CustomElementRegistry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 41133002: Remove virtual destructors for CustomElementDefinition and CustomElementRegistry (Closed)

Created:
7 years, 2 months ago by Inactive

Modified:
7 years, 2 months ago

Reviewers:
dominicc (has gone to gerrit), abarth-chromium

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove virtual destructors for CustomElementDefinition and CustomElementRegistry Remove destructors for CustomElementDefinition and CustomElementRegistry as these were empty and marked as virtual. This avoids creating unnecessary vtables since these classes are never subclasses nor do they have any virtual function. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160505

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	Source/core/dom/custom/CustomElementDefinition.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	Source/core/dom/custom/CustomElementRegistry.h	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/41133002/1

7 years, 2 months ago (2013-10-24 22:57:39 UTC) #3

Message was sent while issue was closed.

Change committed as 160505

Expand Messages | Collapse Messages