Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: Source/core/dom/custom/CustomElementRegistry.h

Issue 41133002: Remove virtual destructors for CustomElementDefinition and CustomElementRegistry (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/custom/CustomElementDefinition.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 class CustomElementConstructorBuilder; 46 class CustomElementConstructorBuilder;
47 class Document; 47 class Document;
48 class ExceptionState; 48 class ExceptionState;
49 49
50 class CustomElementRegistry { 50 class CustomElementRegistry {
51 WTF_MAKE_NONCOPYABLE(CustomElementRegistry); 51 WTF_MAKE_NONCOPYABLE(CustomElementRegistry);
52 protected: 52 protected:
53 friend class CustomElementRegistrationContext; 53 friend class CustomElementRegistrationContext;
54 54
55 CustomElementRegistry() { } 55 CustomElementRegistry() { }
56 virtual ~CustomElementRegistry() { }
57 56
58 CustomElementDefinition* registerElement(Document*, CustomElementConstructor Builder*, const AtomicString& name, CustomElement::NameSet validNames, Exception State&); 57 CustomElementDefinition* registerElement(Document*, CustomElementConstructor Builder*, const AtomicString& name, CustomElement::NameSet validNames, Exception State&);
59 CustomElementDefinition* find(const CustomElementDescriptor&) const; 58 CustomElementDefinition* find(const CustomElementDescriptor&) const;
60 59
61 private: 60 private:
62 typedef HashMap<CustomElementDescriptor, RefPtr<CustomElementDefinition> > D efinitionMap; 61 typedef HashMap<CustomElementDescriptor, RefPtr<CustomElementDefinition> > D efinitionMap;
63 DefinitionMap m_definitions; 62 DefinitionMap m_definitions;
64 HashSet<AtomicString> m_registeredTypeNames; 63 HashSet<AtomicString> m_registeredTypeNames;
65 }; 64 };
66 65
67 } // namespace WebCore 66 } // namespace WebCore
68 67
69 #endif 68 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/custom/CustomElementDefinition.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698