Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: Source/core/dom/custom/CustomElementDefinition.h

Issue 41133002: Remove virtual destructors for CustomElementDefinition and CustomElementRegistry (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/dom/custom/CustomElementRegistry.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 25 matching lines...) Expand all
36 #include "wtf/Forward.h" 36 #include "wtf/Forward.h"
37 #include "wtf/PassRefPtr.h" 37 #include "wtf/PassRefPtr.h"
38 #include "wtf/RefCounted.h" 38 #include "wtf/RefCounted.h"
39 39
40 namespace WebCore { 40 namespace WebCore {
41 41
42 class CustomElementDefinition : public RefCounted<CustomElementDefinition> { 42 class CustomElementDefinition : public RefCounted<CustomElementDefinition> {
43 public: 43 public:
44 static PassRefPtr<CustomElementDefinition> create(const CustomElementDescrip tor&, PassRefPtr<CustomElementLifecycleCallbacks>); 44 static PassRefPtr<CustomElementDefinition> create(const CustomElementDescrip tor&, PassRefPtr<CustomElementLifecycleCallbacks>);
45 45
46 virtual ~CustomElementDefinition() { }
47
48 const CustomElementDescriptor& descriptor() const { return m_descriptor; } 46 const CustomElementDescriptor& descriptor() const { return m_descriptor; }
49 CustomElementLifecycleCallbacks* callbacks() const { return m_callbacks.get( ); } 47 CustomElementLifecycleCallbacks* callbacks() const { return m_callbacks.get( ); }
50 48
51 private: 49 private:
52 CustomElementDefinition(const CustomElementDescriptor&, PassRefPtr<CustomEle mentLifecycleCallbacks>); 50 CustomElementDefinition(const CustomElementDescriptor&, PassRefPtr<CustomEle mentLifecycleCallbacks>);
53 51
54 CustomElementDescriptor m_descriptor; 52 CustomElementDescriptor m_descriptor;
55 RefPtr<CustomElementLifecycleCallbacks> m_callbacks; 53 RefPtr<CustomElementLifecycleCallbacks> m_callbacks;
56 }; 54 };
57 55
58 } 56 }
59 57
60 #endif // CustomElementDefinition_h 58 #endif // CustomElementDefinition_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/custom/CustomElementRegistry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698