Colored Emoji not drawn in Chrome if font style is set as Bold

src/ports/SkFontHost_FreeType.cpp

 
 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkAdvancedTypefaceMetrics.h"
 #include "SkBitmap.h"
@@ skipping 1004 matching lines @@
                                     fFace, fScaleX, fScaleY,      err));
             fFace = NULL;
             return;
         }
         FT_Set_Transform(fFace, &fMatrix22, NULL);
     } else if (FT_HAS_FIXED_SIZES(fFace)) {
         fStrikeIndex = chooseBitmapStrike(fFace, fScaleY);
         if (fStrikeIndex == -1) {
             SkDEBUGF(("no glyphs for font \"%s\" size %f?\n",
                             fFace->family_name,       SkFixedToScalar(fScaleY)));
+            updateImageFromPath(true);

[reed1, 2014/09/05 13:29:42]

nit: prefix method calls with this->

[h.joshi, 2014/09/05 14:06:31]

Done.

         } else {
             // FreeType does no provide linear metrics for bitmap fonts.
             linearMetrics = false;
 
             // FreeType documentation says:
             // FT_LOAD_NO_BITMAP -- Ignore bitmap strikes when loading.
             // Bitmap-only fonts ignore this flag.
             //
             // However, in FreeType 2.5.1 color bitmap only fonts do not ignore this flag.
             // Force this flag off for bitmap only fonts.
             fLoadGlyphFlags &= ~FT_LOAD_NO_BITMAP;
+            updateImageFromPath(false);
         }
     } else {
         SkDEBUGF(("unknown kind of font \"%s\" size %f?\n",
                             fFace->family_name,       SkFixedToScalar(fScaleY)));
     }
 
     fDoLinearMetrics = linearMetrics;
 }
 
 SkScalerContext_FreeType::~SkScalerContext_FreeType() {
@@ skipping 207 matching lines @@
         if (fRec.fFlags & SkScalerContext::kVertical_Flag) {
             FT_Vector vector;
             vector.x = fFace->glyph->metrics.vertBearingX - fFace->glyph->metrics.horiBearingX;
             vector.y = -fFace->glyph->metrics.vertBearingY - fFace->glyph->metrics.horiBearingY;
             FT_Vector_Transform(&vector, &fMatrix22);
             fFace->glyph->bitmap_left += SkFDot6Floor(vector.x);
             fFace->glyph->bitmap_top  += SkFDot6Floor(vector.y);
         }
 
         if (fFace->glyph->bitmap.pixel_mode == FT_PIXEL_MODE_BGRA) {
+            updateImageFromPath(false);
             glyph->fMaskFormat = SkMask::kARGB32_Format;
-        }
+        } else
+            updateImageFromPath(true);
 
         glyph->fWidth   = SkToU16(fFace->glyph->bitmap.width);
         glyph->fHeight  = SkToU16(fFace->glyph->bitmap.rows);
         glyph->fTop     = -SkToS16(fFace->glyph->bitmap_top);
         glyph->fLeft    = SkToS16(fFace->glyph->bitmap_left);
         break;
 
       default:
         SkDEBUGFAIL("unknown glyph format");
         goto ERROR;
@@ skipping 445 matching lines @@
         *style = (SkTypeface::Style) tempStyle;
     }
     if (isFixedPitch) {
         *isFixedPitch = FT_IS_FIXED_WIDTH(face);
     }
 
     FT_Done_Face(face);
     FT_Done_FreeType(library);
     return true;
 }