Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 410173002: Make ScreenOrientationProvider (Java) a bag of static methods. (Closed)

Created:
6 years, 5 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make ScreenOrientationProvider (Java) a bag of static methods. BUG=162827 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285004

Patch Set 1 #

Total comments: 2

Messages

Total messages: 7 (0 generated)
mlamouri (slow - plz ping)
6 years, 5 months ago (2014-07-23 14:20:09 UTC) #1
Michael van Ouwerkerk
lgtm with a question https://codereview.chromium.org/410173002/diff/1/content/browser/screen_orientation/screen_orientation_provider_android.h File content/browser/screen_orientation/screen_orientation_provider_android.h (right): https://codereview.chromium.org/410173002/diff/1/content/browser/screen_orientation/screen_orientation_provider_android.h#newcode8 content/browser/screen_orientation/screen_orientation_provider_android.h:8: #include <jni.h> What's the difference?
6 years, 5 months ago (2014-07-23 14:44:01 UTC) #2
mlamouri (slow - plz ping)
https://codereview.chromium.org/410173002/diff/1/content/browser/screen_orientation/screen_orientation_provider_android.h File content/browser/screen_orientation/screen_orientation_provider_android.h (right): https://codereview.chromium.org/410173002/diff/1/content/browser/screen_orientation/screen_orientation_provider_android.h#newcode8 content/browser/screen_orientation/screen_orientation_provider_android.h:8: #include <jni.h> On 2014/07/23 14:44:01, Michael van Ouwerkerk wrote: ...
6 years, 5 months ago (2014-07-23 14:51:33 UTC) #3
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 5 months ago (2014-07-23 14:51:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/410173002/1
6 years, 5 months ago (2014-07-23 14:52:21 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 16:25:57 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 18:59:23 UTC) #7
Message was sent while issue was closed. 
Change committed as 285004

Powered by Google App Engine
This is Rietveld 408576698