content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationProviderTest.java - Issue 410173002: Make ScreenOrientationProvider (Java) a bag of static methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationProviderTest.java

Issue 410173002: Make ScreenOrientationProvider (Java) a bag of static methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/screen_orientation/screen_orientation_provider_android.h ('K') | « content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationProviderTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationProviderTest.java b/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationProviderTest.java

index 5f14424288c6cddb3efffa6f10c3c93e7f92090f..0b8f434544cad053e60f47d7a3aade178733212a 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationProviderTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationProviderTest.java

@@ -29,7 +29,6 @@ public class ScreenOrientationProviderTest extends ContentShellTestBase {

UrlUtils.encodeHtmlDataUri("<html><body>foo</body></html>");

private MockOrientationObserver mObserver;

- private final ScreenOrientationProvider mProvider = ScreenOrientationProvider.create();

private boolean checkOrientationForLock(int orientations) {

switch (orientations) {

@@ -58,7 +57,7 @@ public class ScreenOrientationProviderTest extends ContentShellTestBase {

* Locks the screen orientation to |orientations| using ScreenOrientationProvider.

private void lockOrientation(int orientations) {

- mProvider.lockOrientation((byte)orientations);

+ ScreenOrientationProvider.lockOrientation((byte)orientations);

}

/**

@@ -78,7 +77,7 @@ public class ScreenOrientationProviderTest extends ContentShellTestBase {

* Unlock the screen orientation using |ScreenOrientationProvider|.

private void unlockOrientation() {

- mProvider.unlockOrientation();

+ ScreenOrientationProvider.unlockOrientation();

}

@Override