content/browser/screen_orientation/screen_orientation_provider_android.h - Issue 410173002: Make ScreenOrientationProvider (Java) a bag of static methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/screen_orientation/screen_orientation_provider_android.h

Issue 410173002: Make ScreenOrientationProvider (Java) a bag of static methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/screen_orientation/screen_orientation_provider.h ('k') | content/browser/screen_orientation/screen_orientation_provider_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/screen_orientation/screen_orientation_provider_android.h

diff --git a/content/browser/screen_orientation/screen_orientation_provider_android.h b/content/browser/screen_orientation/screen_orientation_provider_android.h

index 394e5e64549c4fe8507911482eb855a9584e72b4..eac7cce8537cbfcce32f44deb17a3c67c5e8a2a1 100644

--- a/content/browser/screen_orientation/screen_orientation_provider_android.h

+++ b/content/browser/screen_orientation/screen_orientation_provider_android.h

@@ -5,7 +5,8 @@

#ifndef CONTENT_BROWSER_SCREEN_ORIENTATION_SCREEN_ORIENTATION_PROVIDER_ANDROID_H_

#define CONTENT_BROWSER_SCREEN_ORIENTATION_SCREEN_ORIENTATION_PROVIDER_ANDROID_H_

-#include "base/android/jni_android.h"

+#include <jni.h>

Michael van Ouwerkerk 2014/07/23 14:44:01 What's the difference?

mlamouri (slow - plz ping) 2014/07/23 14:51:33 It will include less stuff. I needed JNIEnv and ba

#include "base/compiler_specific.h"

#include "content/browser/screen_orientation/screen_orientation_provider.h"

#include "content/public/browser/web_contents_observer.h"

@@ -46,8 +47,6 @@ class ScreenOrientationProviderAndroid : public ScreenOrientationProvider,

virtual ~ScreenOrientationProviderAndroid();

- base::android::ScopedJavaGlobalRef<jobject> j_screen_orientation_provider_;

// ScreenOrientationDispatcherHost owns ScreenOrientationProvider so

// dispatcher_ should not point to an invalid memory.

ScreenOrientationDispatcherHost* dispatcher_;