Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 410043002: Disable all the browser_tests that are flaking more than 5% of the time on trybots. (Closed)

Created:
6 years, 5 months ago by jam
Modified:
6 years, 5 months ago
CC:
chromium-reviews, davidben+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, plundblad+watch_chromium.org, gavinp+prer_chromium.org, aboxhall+watch_chromium.org, tfarina, yoshiki+watch_chromium.org, dominich+watch_chromium.org, yuzo+watch_chromium.org, tburkard+watch_chromium.org, rginda+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more #

Total comments: 2

Patch Set 3 : review comments #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -99 lines) Patch
M chrome/browser/chromeos/extensions/virtual_keyboard_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 5 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/system/tray_accessibility_browsertest.cc View 1 2 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/automation/automation_apitest.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_incognito_apitest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_apitest.cc View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/extensions/lazy_background_page_apitest.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 2 chunks +4 lines, -17 lines 0 comments Download
M chrome/browser/profiles/profile_manager_browsertest.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 3 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/test/ppapi/ppapi_browsertest.cc View 1 2 3 3 chunks +10 lines, -20 lines 0 comments Download
M extensions/renderer/script_context_browsertest.cc View 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jabdelmalek
6 years, 5 months ago (2014-07-23 02:52:21 UTC) #1
viettrungluu
https://codereview.chromium.org/410043002/diff/20001/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc File chrome/browser/chromeos/system/tray_accessibility_browsertest.cc (right): https://codereview.chromium.org/410043002/diff/20001/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc#newcode274 chrome/browser/chromeos/system/tray_accessibility_browsertest.cc:274: IN_PROC_BROWSER_TEST_P(TrayAccessibilityTest, ShowTrayIcon) { You should be able to disable ...
6 years, 5 months ago (2014-07-23 15:35:02 UTC) #2
jam
https://codereview.chromium.org/410043002/diff/20001/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc File chrome/browser/chromeos/system/tray_accessibility_browsertest.cc (right): https://codereview.chromium.org/410043002/diff/20001/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc#newcode274 chrome/browser/chromeos/system/tray_accessibility_browsertest.cc:274: IN_PROC_BROWSER_TEST_P(TrayAccessibilityTest, ShowTrayIcon) { On 2014/07/23 15:35:02, viettrungluu wrote: > ...
6 years, 5 months ago (2014-07-23 16:28:26 UTC) #3
viettrungluu
lgtm
6 years, 5 months ago (2014-07-23 16:34:28 UTC) #4
jam
6 years, 5 months ago (2014-07-23 17:05:35 UTC) #5
tbr kalman for src/extensions

Powered by Google App Engine
This is Rietveld 408576698