chrome/browser/profiles/profile_manager_browsertest.cc - Issue 410043002: Disable all the browser_tests that are flaking more than 5% of the time on trybots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_manager_browsertest.cc

Issue 410043002: Disable all the browser_tests that are flaking more than 5% of the time on trybots. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_manager_browsertest.cc

diff --git a/chrome/browser/profiles/profile_manager_browsertest.cc b/chrome/browser/profiles/profile_manager_browsertest.cc

index d4806016375717f908fdfb980d1ae5430f3c2e23..7b41e23e19760ee00053f4d467845c7ff95500a6 100644

--- a/chrome/browser/profiles/profile_manager_browsertest.cc

+++ b/chrome/browser/profiles/profile_manager_browsertest.cc

@@ -330,9 +330,13 @@ IN_PROC_BROWSER_TEST_F(ProfileManagerBrowserTest,

EXPECT_EQ(path_profile2, browser_list->get(1)->profile()->GetPath());

}

-// This test used to be flakily timing out on Windows: http://crbug.com/314905.

-// If this happens again please make it a MAYBE_ test and reopen that bug.

-IN_PROC_BROWSER_TEST_F(ProfileManagerBrowserTest, EphemeralProfile) {

+// Flakes on Windows: http://crbug.com/314905

+#if defined(OS_WIN)

+#define MAYBE_EphemeralProfile DISABLED_EphemeralProfile

+#else

+#define MAYBE_EphemeralProfile EphemeralProfile

+#endif

+IN_PROC_BROWSER_TEST_F(ProfileManagerBrowserTest, MAYBE_EphemeralProfile) {

#if defined(OS_WIN) && defined(USE_ASH)

// Disable this test in Metro+Ash for now (http://crbug.com/262796).

if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests))