Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2661)

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc

Issue 410043002: Disable all the browser_tests that are flaking more than 5% of the time on trybots. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc b/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
index dd11aacea3d0a8594124442c237edbad2196ad57..e9b485d86a88a4420e14851044de9abb13adcba0 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
@@ -102,14 +102,9 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewTest, MAYBE_TaskManagerNewPrintPreview) {
WaitForTaskManagerRows(1, MatchPrint(url::kAboutBlankURL)));
}
-// Disable the test for mac as it started being flaky, see http://crbug/367665.
-#if defined(OS_MACOSX) && !defined(OS_IOS)
-#define MAYBE_TaskManagerExistingPrintPreview DISABLED_TaskManagerExistingPrintPreview
-#else
-#define MAYBE_TaskManagerExistingPrintPreview TaskManagerExistingPrintPreview
-#endif
+// http://crbug/367665.
IN_PROC_BROWSER_TEST_F(PrintPreviewTest,
- MAYBE_TaskManagerExistingPrintPreview) {
+ DISABLED_TaskManagerExistingPrintPreview) {
// Create the print preview dialog.
Print();
@@ -183,7 +178,8 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewTest, WindowedNPAPIPluginHidden) {
ASSERT_FALSE(rects_equal);
}
-IN_PROC_BROWSER_TEST_F(PrintPreviewTest, NoCrashOnCloseWithOtherTabs) {
+// http://crbug.com/396360
+IN_PROC_BROWSER_TEST_F(PrintPreviewTest, DISABLED_NoCrashOnCloseWithOtherTabs) {
// Now print preview.
Print();
« no previous file with comments | « chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc ('k') | chrome/test/ppapi/ppapi_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698