Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1623)

Unified Diff: Tools/GardeningServer/model/ct-commit-log.html

Issue 409063002: Simplify failing builder lists. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: make resultTypes private Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/model/ct-commit-log.html
diff --git a/Tools/GardeningServer/model/ct-commit-log.html b/Tools/GardeningServer/model/ct-commit-log.html
index 4de8253b3eca015a48174b445d0ba3bf084d2af7..29ba9ed3baaed33838dcf05b607869a2cc492a43 100644
--- a/Tools/GardeningServer/model/ct-commit-log.html
+++ b/Tools/GardeningServer/model/ct-commit-log.html
@@ -30,9 +30,8 @@ CTCommitLog.prototype._processXml = function(xml) {
var author = logentry.getElementsByTagName('author')[0].textContent.trim();
var message = logentry.getElementsByTagName('content')[0].textContent.trim();
// FIXME: Handle base urls for different repos.
- // FIXME: This class should import config.js if it keeps using config.*.
- var commit = new CTCommit(author, message, config.kBlinkRevisionURL);
+ var commit = new CTCommit(author, message, 'http://src.chromium.org/viewvc/blink');
michaelpg 2014/07/22 05:58:23 why is it better for this to be hard-coded? what w
ojan 2014/07/22 06:08:50 We'll need to pass this information through in the
this.commits[commit.revision] = commit;
}.bind(this));
}
-</script>
+</script>
« no previous file with comments | « no previous file | Tools/GardeningServer/model/ct-commit-mock.html » ('j') | Tools/GardeningServer/ui/ct-builder.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698