Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 408833004: Revert 284417 "Move default user profile images strings and reso..." (Closed)

Created:
6 years, 5 months ago by Nikita (slow)
Modified:
6 years, 5 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 284417 "Move default user profile images strings and reso..." > Move default user profile images strings and resources out of src/chrome. > > BUG=387614 > R=bauerb@chromium.org, oshima@chromium.org > TBR=tony@chromium.org > > Review URL: https://codereview.chromium.org/400973002 TBR=nkostylev@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284419

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -654 lines) Patch
M trunk/src/chrome/app/chromeos_strings.grdp View 2 chunks +207 lines, -0 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_beaker.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_bee.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_bicycle.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_bokeh.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_briefcase.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_chess.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_circles.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_cloud.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_coffee.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_cupcake.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_day.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_dragonfly.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_flower.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_frog.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_ganzania.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_globe.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_hotair.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_jackrussellterrier.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_jellyfish.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_kiwi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_ladybug.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_leaf.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_night.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_penguin.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_plane.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_rainbowfish.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_recordplayer.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_robot_body.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_robot_head.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_toolbox.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_upsidedown.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_user_color.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_100_percent/avatar_user_enterprise.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_200_percent/avatar_bicycle.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_200_percent/avatar_bokeh.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_200_percent/avatar_chess.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_200_percent/avatar_coffee.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_200_percent/avatar_dragonfly.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_200_percent/avatar_frog.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_200_percent/avatar_ganzania.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_200_percent/avatar_jackrussellterrier.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_200_percent/avatar_jellyfish.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_200_percent/avatar_kiwi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_200_percent/avatar_penguin.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_200_percent/avatar_rainbowfish.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_200_percent/avatar_recordplayer.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/app/theme/default_200_percent/avatar_upsidedown.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/app/theme/theme_resources.grd View 1 chunk +33 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/screens/user_image_screen.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc View 3 chunks +5 lines, -8 lines 0 comments Download
A + trunk/src/chrome/browser/chromeos/login/users/avatar/default_user_images.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/chromeos/login/users/avatar/default_user_images.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc View 11 chunks +36 lines, -58 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc View 8 chunks +14 lines, -18 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/users/user.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/users/user.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D trunk/src/chrome/browser/supervised_user/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/supervised_user/supervised_user_sync_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/supervised_user/supervised_user_sync_service_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc View 3 chunks +7 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc View 8 chunks +24 lines, -31 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/options/chromeos/user_image_source.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/components/user_manager.gypi View 2 chunks +5 lines, -13 lines 0 comments Download
M trunk/src/components/user_manager/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D trunk/src/components/user_manager/user_image/default_user_images.h View 1 chunk +0 lines, -76 lines 0 comments Download
D trunk/src/components/user_manager/user_image/default_user_images.cc View 1 chunk +0 lines, -203 lines 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_beaker.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_bee.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_bicycle.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_bokeh.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_briefcase.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_chess.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_circles.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_cloud.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_coffee.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_cupcake.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_day.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_dragonfly.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_flower.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_frog.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_ganzania.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_globe.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_hotair.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_jackrussellterrier.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_jellyfish.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_kiwi.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_ladybug.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_leaf.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_night.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_penguin.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_plane.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_rainbowfish.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_recordplayer.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_robot_body.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_robot_head.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_toolbox.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_upsidedown.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_user_color.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/default_user_images/avatar_user_enterprise.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/default_user_images/avatar_bicycle.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/default_user_images/avatar_bokeh.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/default_user_images/avatar_chess.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/default_user_images/avatar_coffee.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/default_user_images/avatar_dragonfly.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/default_user_images/avatar_frog.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/default_user_images/avatar_ganzania.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/default_user_images/avatar_jackrussellterrier.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/default_user_images/avatar_jellyfish.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/default_user_images/avatar_kiwi.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/default_user_images/avatar_penguin.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/default_user_images/avatar_rainbowfish.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/default_user_images/avatar_recordplayer.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/default_user_images/avatar_upsidedown.png View Binary file 0 comments Download
M trunk/src/ui/chromeos/resources/ui_chromeos_resources.grd View 1 chunk +0 lines, -35 lines 0 comments Download
M trunk/src/ui/chromeos/ui_chromeos_strings.grd View 1 chunk +0 lines, -208 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nikita (slow)
6 years, 5 months ago (2014-07-21 13:12:18 UTC) #1
Nikita (slow)
6 years, 5 months ago (2014-07-21 13:12:50 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r284419 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698