Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: trunk/src/chrome/browser/chromeos/login/screens/user_image_screen.cc

Issue 408833004: Revert 284417 "Move default user profile images strings and reso..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/chromeos/login/screens/user_image_screen.cc
===================================================================
--- trunk/src/chrome/browser/chromeos/login/screens/user_image_screen.cc (revision 284418)
+++ trunk/src/chrome/browser/chromeos/login/screens/user_image_screen.cc (working copy)
@@ -20,6 +20,7 @@
#include "chrome/browser/chromeos/camera_presence_notifier.h"
#include "chrome/browser/chromeos/login/login_utils.h"
#include "chrome/browser/chromeos/login/screens/screen_observer.h"
+#include "chrome/browser/chromeos/login/users/avatar/default_user_images.h"
#include "chrome/browser/chromeos/login/users/avatar/user_image_manager.h"
#include "chrome/browser/chromeos/login/users/user_manager.h"
#include "chrome/browser/chromeos/login/wizard_controller.h"
@@ -31,7 +32,6 @@
#include "components/policy/core/common/policy_map.h"
#include "components/policy/core/common/policy_namespace.h"
#include "components/policy/core/common/policy_service.h"
-#include "components/user_manager/user_image/default_user_images.h"
#include "components/user_manager/user_image/user_image.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/notification_service.h"
@@ -167,7 +167,7 @@
return;
int user_image_index = User::kInvalidImageIndex;
if (image_type == "default" &&
- user_manager::IsDefaultImageUrl(image_url, &user_image_index)) {
+ IsDefaultImageUrl(image_url, &user_image_index)) {
selected_image_ = user_image_index;
} else if (image_type == "camera") {
selected_image_ = User::kExternalImageIndex;
@@ -190,23 +190,22 @@
}
image_manager->SaveUserImage(
user_manager::UserImage::CreateAndEncode(user_photo_));
- uma_index = user_manager::kHistogramImageFromCamera;
+ uma_index = kHistogramImageFromCamera;
break;
case User::kProfileImageIndex:
image_manager->SaveUserImageFromProfileImage();
- uma_index = user_manager::kHistogramImageFromProfile;
+ uma_index = kHistogramImageFromProfile;
break;
default:
- DCHECK(selected_image_ >= 0 &&
- selected_image_ < user_manager::kDefaultImagesCount);
+ DCHECK(selected_image_ >= 0 && selected_image_ < kDefaultImagesCount);
image_manager->SaveUserDefaultImageIndex(selected_image_);
- uma_index = user_manager::GetDefaultImageHistogramValue(selected_image_);
+ uma_index = GetDefaultImageHistogramValue(selected_image_);
break;
}
if (user_has_selected_image_) {
UMA_HISTOGRAM_ENUMERATION("UserImage.FirstTimeChoice",
uma_index,
- user_manager::kHistogramImagesCount);
+ kHistogramImagesCount);
}
ExitScreen();
}

Powered by Google App Engine
This is Rietveld 408576698