Move default user profile images strings and resources out of src/chrome.

Move default user profile images strings and resources out of src/chrome.

BUG=387614
R=bauerb@chromium.org, oshima@chromium.org
TBR=tony@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284417

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284429

[Nikita (slow), 2014-07-18 13:01:42]

bauerb@ for
chrome/browser/supervised_user/*

oshima@ the rest.

[oshima, 2014-07-18 13:44:12]

On 2014/07/18 13:01:42, Nikita Kostylev wrote:
> bauerb@ for
> chrome/browser/supervised_user/*
> 
> oshima@ the rest.

lgtm

looks like there are several missing resources for 2x scale. can you ask UX
folks to create them?

[Nikita (slow), 2014-07-18 13:48:16]

On 2014/07/18 13:44:12, oshima (OOO) until July 21) wrote:
> On 2014/07/18 13:01:42, Nikita Kostylev wrote:
> > bauerb@ for
> > chrome/browser/supervised_user/*
> > 
> > oshima@ the rest.
> 
> lgtm
> 
> looks like there are several missing resources for 2x scale. can you ask UX
> folks to create them?

I don't think this is really needed (and is not possible) since those without 2x
versions are legacy pre-ash resources that are not available for selection
anymore.
Only those users that still use them will see them. Last time we checked
designers don't have originals for those images.

Do you have ideas why bots are not happy with my change?
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...
Builds fine locally.

[oshima, 2014-07-18 14:21:43]

On 2014/07/18 13:48:16, Nikita Kostylev wrote:
> On 2014/07/18 13:44:12, oshima (OOO) until July 21) wrote:
> > On 2014/07/18 13:01:42, Nikita Kostylev wrote:
> > > bauerb@ for
> > > chrome/browser/supervised_user/*
> > > 
> > > oshima@ the rest.
> > 
> > lgtm
> > 
> > looks like there are several missing resources for 2x scale. can you ask UX
> > folks to create them?
> 
> I don't think this is really needed (and is not possible) since those without
2x
> versions are legacy pre-ash resources that are not available for selection
> anymore.
> Only those users that still use them will see them. Last time we checked
> designers don't have originals for those images.

hmm, so we don't copy them to user's directory? Shouldn't we?

> Do you have ideas why bots are not happy with my change?
>
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...
> Builds fine locally.

Not sure. Maybe bots still have an issue with binary data? Some says it works,
and some says it doesn't.
I've never tried CQ for image change, so I don't know which is correct.
and not sure whic

[Nikita (slow), 2014-07-18 14:32:12]

On 2014/07/18 14:21:43, oshima (OOO) until July 21) wrote:
> On 2014/07/18 13:48:16, Nikita Kostylev wrote:
> > On 2014/07/18 13:44:12, oshima (OOO) until July 21) wrote:
> > > On 2014/07/18 13:01:42, Nikita Kostylev wrote:
> > > > bauerb@ for
> > > > chrome/browser/supervised_user/*
> > > > 
> > > > oshima@ the rest.
> > > 
> > > lgtm
> > > 
> > > looks like there are several missing resources for 2x scale. can you ask
UX
> > > folks to create them?
> > 
> > I don't think this is really needed (and is not possible) since those
without
> 2x
> > versions are legacy pre-ash resources that are not available for selection
> > anymore.
> > Only those users that still use them will see them. Last time we checked
> > designers don't have originals for those images.
> 
> hmm, so we don't copy them to user's directory? Shouldn't we?

You mean default images? We use them from resources.

[Bernhard Bauer, 2014-07-21 08:59:03]

Trivially LGTM

[Nikita (slow), 2014-07-21 12:15:29]

TBR'ing OWNERS of these new dependencies that were added to user_manager/DEPS

tony@:
+ui/base/l10n
+ui/base/resource

[Nikita (slow), 2014-07-21 12:40:02]

Committed patchset #4 manually as r284417 (presubmit successful).

[Nikita (slow), 2014-07-21 14:27:40]

Ok, I'm splitting this CL. First part (this one) will only move strings and
resources.

Second part will move constants and helper functions, one that was breaking the
clang build.

[Nikita (slow), 2014-07-21 15:16:16]

Committed patchset #9 manually as r284429 (presubmit successful).

[Nikita (slow), 2014-07-21 16:16:50]

2x resources were accidentally missed in this CL so I've created follow up that
moves them as well.

[Nikita (slow), 2014-07-21 16:16:58]

On 2014/07/21 16:16:50, Nikita Kostylev wrote:
> 2x resources were accidentally missed in this CL so I've created follow up
that
> moves them as well.

https://codereview.chromium.org/398823009/

[oshima, 2014-07-23 00:52:33]

On 2014/07/18 14:32:12, Nikita Kostylev wrote:
> On 2014/07/18 14:21:43, oshima (OOO) until July 21) wrote:
> > On 2014/07/18 13:48:16, Nikita Kostylev wrote:
> > > On 2014/07/18 13:44:12, oshima (OOO) until July 21) wrote:
> > > > On 2014/07/18 13:01:42, Nikita Kostylev wrote:
> > > > > bauerb@ for
> > > > > chrome/browser/supervised_user/*
> > > > > 
> > > > > oshima@ the rest.
> > > > 
> > > > lgtm
> > > > 
> > > > looks like there are several missing resources for 2x scale. can you ask
> UX
> > > > folks to create them?
> > > 
> > > I don't think this is really needed (and is not possible) since those
> without
> > 2x
> > > versions are legacy pre-ash resources that are not available for selection
> > > anymore.
> > > Only those users that still use them will see them. Last time we checked
> > > designers don't have originals for those images.
> > 
> > hmm, so we don't copy them to user's directory? Shouldn't we?
> 
> You mean default images? We use them from resources.

Do we need to use them from resources? Given that we already allow a user to use
their own image,
it may actually simplify the code by copying the assets?

[Nikita (slow), 2014-07-23 08:44:33]

On 2014/07/23 00:52:33, oshima wrote:
> On 2014/07/18 14:32:12, Nikita Kostylev wrote:
> > On 2014/07/18 14:21:43, oshima (OOO) until July 21) wrote:
> > > On 2014/07/18 13:48:16, Nikita Kostylev wrote:
> > > > On 2014/07/18 13:44:12, oshima (OOO) until July 21) wrote:
> > > > > On 2014/07/18 13:01:42, Nikita Kostylev wrote:
> > > > > > bauerb@ for
> > > > > > chrome/browser/supervised_user/*
> > > > > > 
> > > > > > oshima@ the rest.
> > > > > 
> > > > > lgtm
> > > > > 
> > > > > looks like there are several missing resources for 2x scale. can you
ask
> > UX
> > > > > folks to create them?
> > > > 
> > > > I don't think this is really needed (and is not possible) since those
> > without
> > > 2x
> > > > versions are legacy pre-ash resources that are not available for
selection
> > > > anymore.
> > > > Only those users that still use them will see them. Last time we checked
> > > > designers don't have originals for those images.
> > > 
> > > hmm, so we don't copy them to user's directory? Shouldn't we?
> > 
> > You mean default images? We use them from resources.
> 
> Do we need to use them from resources? Given that we already allow a user to
use
> their own image,
> it may actually simplify the code by copying the assets?

Sorry, I didn't fully understand what you're suggesting?
These default images have to be part of resources since they're identified in
Local State just as index.

What exactly are you suggesting?

[Nikita (slow), 2014-07-23 12:46:19]

On 2014/07/23 08:44:33, Nikita Kostylev wrote:
> On 2014/07/23 00:52:33, oshima wrote:
> > On 2014/07/18 14:32:12, Nikita Kostylev wrote:
> > > On 2014/07/18 14:21:43, oshima (OOO) until July 21) wrote:
> > > > On 2014/07/18 13:48:16, Nikita Kostylev wrote:
> > > > > On 2014/07/18 13:44:12, oshima (OOO) until July 21) wrote:
> > > > > > On 2014/07/18 13:01:42, Nikita Kostylev wrote:
> > > > > > > bauerb@ for
> > > > > > > chrome/browser/supervised_user/*
> > > > > > > 
> > > > > > > oshima@ the rest.
> > > > > > 
> > > > > > lgtm
> > > > > > 
> > > > > > looks like there are several missing resources for 2x scale. can you
> ask
> > > UX
> > > > > > folks to create them?
> > > > > 
> > > > > I don't think this is really needed (and is not possible) since those
> > > without
> > > > 2x
> > > > > versions are legacy pre-ash resources that are not available for
> selection
> > > > > anymore.
> > > > > Only those users that still use them will see them. Last time we
checked
> > > > > designers don't have originals for those images.
> > > > 
> > > > hmm, so we don't copy them to user's directory? Shouldn't we?
> > > 
> > > You mean default images? We use them from resources.
> > 
> > Do we need to use them from resources? Given that we already allow a user to
> use
> > their own image,
> > it may actually simplify the code by copying the assets?
> 
> Sorry, I didn't fully understand what you're suggesting?
> These default images have to be part of resources since they're identified in
> Local State just as index.
> 
> What exactly are you suggesting?

Are you suggesting just save default image as a file and use that instead?
This would break existing users that already have default image selected and
just reference it chrome://theme/*
Also I don't think this is feasible to change existing implementation.
When this index is synced on Chromebook we don't have to save file as well, just
index.