Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc

Issue 408493002: Make Clone, Contains, Equal and IPC function non-virtual and implement in manifest_permission.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src@warnings
Patch Set: Remove DCHECK Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc
diff --git a/chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc b/chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc
index 2c5c759371b801eb0517186067345122f67dd930..291631bcb23d0e2db6f7bf9aacbbd90d681ffde6 100644
--- a/chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc
+++ b/chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc
@@ -63,12 +63,6 @@ class UIOverridesHandler::ManifestPermissionImpl : public ManifestPermission {
new base::FundamentalValue(override_bookmarks_ui_permission_)).Pass();
}
- virtual ManifestPermission* Clone() const OVERRIDE {
- return scoped_ptr<ManifestPermissionImpl>(
- new ManifestPermissionImpl(
- override_bookmarks_ui_permission_)).release();
- }
-
virtual ManifestPermission* Diff(const ManifestPermission* rhs) const
OVERRIDE {
const ManifestPermissionImpl* other =
@@ -99,34 +93,6 @@ class UIOverridesHandler::ManifestPermissionImpl : public ManifestPermission {
other->override_bookmarks_ui_permission_)).release();
}
- virtual bool Contains(const ManifestPermission* rhs) const OVERRIDE {
- const ManifestPermissionImpl* other =
- static_cast<const ManifestPermissionImpl*>(rhs);
-
- return !other->override_bookmarks_ui_permission_ ||
- override_bookmarks_ui_permission_;
- }
-
- virtual bool Equal(const ManifestPermission* rhs) const OVERRIDE {
- const ManifestPermissionImpl* other =
- static_cast<const ManifestPermissionImpl*>(rhs);
-
- return override_bookmarks_ui_permission_ ==
- other->override_bookmarks_ui_permission_;
- }
-
- virtual void Write(IPC::Message* m) const OVERRIDE {
- IPC::WriteParam(m, override_bookmarks_ui_permission_);
- }
-
- virtual bool Read(const IPC::Message* m, PickleIterator* iter) OVERRIDE {
- return IPC::ReadParam(m, iter, &override_bookmarks_ui_permission_);
- }
-
- virtual void Log(std::string* log) const OVERRIDE {
- IPC::LogParam(override_bookmarks_ui_permission_, log);
- }
-
private:
bool override_bookmarks_ui_permission_;
};

Powered by Google App Engine
This is Rietveld 408576698