Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8258)

Unified Diff: chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.cc

Issue 408493002: Make Clone, Contains, Equal and IPC function non-virtual and implement in manifest_permission.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src@warnings
Patch Set: Remove DCHECK Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.cc
diff --git a/chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.cc b/chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.cc
index 2d6670d4ea80fdcf2337a112d6bfcd88e9f1e46d..d92d48ecd71b35e1f7154fe3be8f6940b2877e51 100644
--- a/chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.cc
+++ b/chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.cc
@@ -159,13 +159,6 @@ scoped_ptr<base::Value> BluetoothManifestPermission::ToValue() const {
return bluetooth.ToValue().PassAs<base::Value>();
}
-ManifestPermission* BluetoothManifestPermission::Clone() const {
- scoped_ptr<BluetoothManifestPermission> result(
- new BluetoothManifestPermission());
- result->uuids_ = uuids_;
- return result.release();
-}
-
ManifestPermission* BluetoothManifestPermission::Diff(
const ManifestPermission* rhs) const {
const BluetoothManifestPermission* other =
@@ -202,34 +195,6 @@ ManifestPermission* BluetoothManifestPermission::Intersect(
return result.release();
}
-bool BluetoothManifestPermission::Contains(const ManifestPermission* rhs)
- const {
- const BluetoothManifestPermission* other =
- static_cast<const BluetoothManifestPermission*>(rhs);
-
- return base::STLIncludes(uuids_, other->uuids_);
-}
-
-bool BluetoothManifestPermission::Equal(const ManifestPermission* rhs) const {
- const BluetoothManifestPermission* other =
- static_cast<const BluetoothManifestPermission*>(rhs);
-
- return (uuids_ == other->uuids_);
-}
-
-void BluetoothManifestPermission::Write(IPC::Message* m) const {
- IPC::WriteParam(m, uuids_);
-}
-
-bool BluetoothManifestPermission::Read(const IPC::Message* m,
- PickleIterator* iter) {
- return IPC::ReadParam(m, iter, &uuids_);
-}
-
-void BluetoothManifestPermission::Log(std::string* log) const {
- IPC::LogParam(uuids_, log);
-}
-
void BluetoothManifestPermission::AddPermission(const std::string& uuid) {
uuids_.insert(uuid);
}

Powered by Google App Engine
This is Rietveld 408576698