extensions/common/manifest_handler.h - Issue 408493002: Make Clone, Contains, Equal and IPC function non-virtual and implement in manifest_permission.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_handler.h

Issue 408493002: Make Clone, Contains, Equal and IPC function non-virtual and implement in manifest_permission.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src@warnings

Patch Set: Remove DCHECK Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/api/sockets/sockets_manifest_permission.cc ('k') | extensions/common/permissions/manifest_permission.h » ('j') | extensions/common/permissions/manifest_permission.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/manifest_handler.h

diff --git a/extensions/common/manifest_handler.h b/extensions/common/manifest_handler.h

index 4c7da31eee09a035f3ce3e3bd45177d64a426780..08792d43459ca98a1c2ddfb7ca52806474ddc354 100644

--- a/extensions/common/manifest_handler.h

+++ b/extensions/common/manifest_handler.h

@@ -123,6 +123,7 @@ class ManifestHandlerRegistry {

private:

friend class ManifestHandler;

friend class ScopedTestingManifestHandlerRegistry;

+ friend class MockManifestHandlerRegistry;

friend struct base::DefaultLazyInstanceTraits<ManifestHandlerRegistry>;

ManifestHandlerRegistry();

@@ -137,7 +138,7 @@ class ManifestHandlerRegistry {

std::string* error,

std::vector<InstallWarning>* warnings);

- ManifestPermission* CreatePermission(const std::string& key);

+ virtual ManifestPermission* CreatePermission(const std::string& key);

not at google - send to devlin 2014/07/18 22:02:18 see comment in manifest_permission.cc. it's a sham

aboxhall 2014/07/18 22:38:16 Acknowledged.

void AddExtensionInitialRequiredPermissions(

const Extension* extension,