Issue 406883002: Don't use WebLockOrientationCallback::OnSuccess() with arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 406883002: Don't use WebLockOrientationCallback::OnSuccess() with arguments. (Closed)

Created:
6 years, 5 months ago by mlamouri (slow - plz ping)

Modified:
6 years, 5 months ago

Reviewers:
nasko, Michael van Ouwerkerk

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Don't use WebLockOrientationCallback::OnSuccess() with arguments. Blink doesn't use the arguments anymore, the promise is always resolved with undefined. BUG=162827 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284412

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -69 lines)			Patch
M	content/browser/screen_orientation/screen_orientation_dispatcher_host.cc	View	1 chunk	+1 line, -10 lines	0 comments	Download
M	content/common/screen_orientation_messages.h	View	1 chunk	+5 lines, -7 lines	0 comments	Download
M	content/renderer/screen_orientation/screen_orientation_dispatcher.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	content/renderer/screen_orientation/screen_orientation_dispatcher.cc	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	content/renderer/screen_orientation/screen_orientation_dispatcher_unittest.cc	View	4 chunks	+15 lines, -44 lines	0 comments	Download

Total messages: 6 (0 generated)

mlamouri (slow - plz ping)

nasko@, can you review the changes in: * content/common/screen_orientation_messages.h mvanouwerkerk@, can you review changes in: ...

6 years, 5 months ago (2014-07-21 09:38:08 UTC) #1

mlamouri (slow - plz ping)

The CQ bit was checked by mlamouri@chromium.org

6 years, 5 months ago (2014-07-21 11:02:30 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/406883002/1

6 years, 5 months ago (2014-07-21 11:03:07 UTC) #5

Message was sent while issue was closed.

Change committed as 284412