content/common/screen_orientation_messages.h - Issue 406883002: Don't use WebLockOrientationCallback::OnSuccess() with arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/screen_orientation_messages.h

Issue 406883002: Don't use WebLockOrientationCallback::OnSuccess() with arguments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/screen_orientation/screen_orientation_dispatcher_host.cc ('k') | content/renderer/screen_orientation/screen_orientation_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/screen_orientation_messages.h

diff --git a/content/common/screen_orientation_messages.h b/content/common/screen_orientation_messages.h

index 5cfc6f45299165e893f63af79a22d6994123cd92..c2114d615adebb4c54a7cf0e3197ac5a2806cc3c 100644

--- a/content/common/screen_orientation_messages.h

+++ b/content/common/screen_orientation_messages.h

@@ -34,13 +34,11 @@ IPC_MESSAGE_CONTROL1(ScreenOrientationMsg_OrientationChange,

blink::WebScreenOrientationType /* orientation */ )

// The browser process' response to a ScreenOrientationHostMsg_LockRequest when

-// the lock actually succeeded. The message includes the new |angle| and |type|

-// of orientation. The |request_id| passed when receiving the request is passed

-// back so the renderer process can associate the response to the right request.

-IPC_MESSAGE_ROUTED3(ScreenOrientationMsg_LockSuccess,

- int, /* request_id */

- unsigned, /* angle */

- blink::WebScreenOrientationType /* type */)

+// the lock actually succeeded. The |request_id| passed when receiving the

+// request is passed back so the renderer process can associate the response to

+// the right request.

+IPC_MESSAGE_ROUTED1(ScreenOrientationMsg_LockSuccess,

+ int /* request_id */)

// The browser process' response to a ScreenOrientationHostMsg_LockRequest when

// the lock actually failed. The message includes the |error| type. The