Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: content/common/screen_orientation_messages.h

Issue 406883002: Don't use WebLockOrientationCallback::OnSuccess() with arguments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // IPC messages for screen orientation. 5 // IPC messages for screen orientation.
6 // Multiply-included message file, hence no include guard. 6 // Multiply-included message file, hence no include guard.
7 7
8 #include "content/common/content_export.h" 8 #include "content/common/content_export.h"
9 #include "ipc/ipc_message_macros.h" 9 #include "ipc/ipc_message_macros.h"
10 #include "third_party/WebKit/public/platform/WebLockOrientationError.h" 10 #include "third_party/WebKit/public/platform/WebLockOrientationError.h"
(...skipping 16 matching lines...) Expand all
27 blink::WebLockOrientationErrorNotAvailable, 27 blink::WebLockOrientationErrorNotAvailable,
28 blink::WebLockOrientationErrorCanceled) 28 blink::WebLockOrientationErrorCanceled)
29 29
30 // The browser process informs the renderer process that the screen orientation 30 // The browser process informs the renderer process that the screen orientation
31 // has changed. |orientation| contains the new screen orientation in degrees. 31 // has changed. |orientation| contains the new screen orientation in degrees.
32 // TODO(mlamouri): we could probably get rid of it. 32 // TODO(mlamouri): we could probably get rid of it.
33 IPC_MESSAGE_CONTROL1(ScreenOrientationMsg_OrientationChange, 33 IPC_MESSAGE_CONTROL1(ScreenOrientationMsg_OrientationChange,
34 blink::WebScreenOrientationType /* orientation */ ) 34 blink::WebScreenOrientationType /* orientation */ )
35 35
36 // The browser process' response to a ScreenOrientationHostMsg_LockRequest when 36 // The browser process' response to a ScreenOrientationHostMsg_LockRequest when
37 // the lock actually succeeded. The message includes the new |angle| and |type| 37 // the lock actually succeeded. The |request_id| passed when receiving the
38 // of orientation. The |request_id| passed when receiving the request is passed 38 // request is passed back so the renderer process can associate the response to
39 // back so the renderer process can associate the response to the right request. 39 // the right request.
40 IPC_MESSAGE_ROUTED3(ScreenOrientationMsg_LockSuccess, 40 IPC_MESSAGE_ROUTED1(ScreenOrientationMsg_LockSuccess,
41 int, /* request_id */ 41 int /* request_id */)
42 unsigned, /* angle */
43 blink::WebScreenOrientationType /* type */)
44 42
45 // The browser process' response to a ScreenOrientationHostMsg_LockRequest when 43 // The browser process' response to a ScreenOrientationHostMsg_LockRequest when
46 // the lock actually failed. The message includes the |error| type. The 44 // the lock actually failed. The message includes the |error| type. The
47 // |request_id| passed when receiving the request is passed back so the renderer 45 // |request_id| passed when receiving the request is passed back so the renderer
48 // process can associate the response to the right request. 46 // process can associate the response to the right request.
49 IPC_MESSAGE_ROUTED2(ScreenOrientationMsg_LockError, 47 IPC_MESSAGE_ROUTED2(ScreenOrientationMsg_LockError,
50 int, /* request_id */ 48 int, /* request_id */
51 blink::WebLockOrientationError /* error */) 49 blink::WebLockOrientationError /* error */)
52 50
53 // The renderer process requests the browser process to lock the screen 51 // The renderer process requests the browser process to lock the screen
54 // orientation to the specified |orientations|. The request contains a 52 // orientation to the specified |orientations|. The request contains a
55 // |request_id| that will have to be passed back to the renderer process when 53 // |request_id| that will have to be passed back to the renderer process when
56 // notifying about a success or error (see ScreenOrientationMsg_LockError and 54 // notifying about a success or error (see ScreenOrientationMsg_LockError and
57 // ScreenOrientationMsg_LockSuccess). 55 // ScreenOrientationMsg_LockSuccess).
58 IPC_MESSAGE_ROUTED2(ScreenOrientationHostMsg_LockRequest, 56 IPC_MESSAGE_ROUTED2(ScreenOrientationHostMsg_LockRequest,
59 blink::WebScreenOrientationLockType, /* orientation */ 57 blink::WebScreenOrientationLockType, /* orientation */
60 int /* request_id */) 58 int /* request_id */)
61 59
62 // The renderer process requests the browser process to unlock the screen 60 // The renderer process requests the browser process to unlock the screen
63 // orientation. 61 // orientation.
64 IPC_MESSAGE_ROUTED0(ScreenOrientationHostMsg_Unlock) 62 IPC_MESSAGE_ROUTED0(ScreenOrientationHostMsg_Unlock)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698