If the media controls are visible they should always grab clicks

Source/core/html/shadow/MediaControlElements.h

Index: Source/core/html/shadow/MediaControlElements.h
diff --git a/Source/core/html/shadow/MediaControlElements.h b/Source/core/html/shadow/MediaControlElements.h
index 0b3fe71350fdfe482c9c8fe72b7816bc0de81745..af73ce132a147a93f7130bbc7d918c0138a93e67 100644
--- a/Source/core/html/shadow/MediaControlElements.h
+++ b/Source/core/html/shadow/MediaControlElements.h
@@ -54,6 +54,7 @@ private:
     void startTimer();
     void stopTimer();
     void transitionTimerFired(Timer<MediaControlPanelElement>*);
+    virtual bool keepEventInShadowDOM(Event*) OVERRIDE;
 
     bool m_isDisplayed;
     bool m_opaque;
@@ -128,6 +129,7 @@ private:
 
     virtual const AtomicString& shadowPseudoId() const OVERRIDE;
     virtual void defaultEventHandler(Event*) OVERRIDE;
+    virtual bool keepEventInShadowDOM(Event*) OVERRIDE;

[acolwell GONE FROM CHROMIUM, 2014/07/29 16:23:26]

Perhaps I'm misunderstanding something. Why can't this be placed on
MediaControls instead since it is the parent of all the other controls? IIUC we
are just trying to prevent events from leaking outside of the all controls
right?

[aberent, 2014/07/31 10:52:47]

Unfortunately, to support the overlay play button, the MediaControls have the
same dimensions as the video; so placing this on the MediaControls would prevent
the video getting any clicks. We only want to capture clicks on the control bar,
not on other parts of the video.

 };
 
 // ----------------------------
@@ -165,6 +167,7 @@ private:
 
     virtual const AtomicString& shadowPseudoId() const OVERRIDE;
     virtual void defaultEventHandler(Event*) OVERRIDE;
+    virtual bool keepEventInShadowDOM(Event*) OVERRIDE;
 };
 
 // ----------------------------
@@ -199,6 +202,7 @@ private:
 
     virtual const AtomicString& shadowPseudoId() const OVERRIDE;
     virtual void defaultEventHandler(Event*) OVERRIDE;
+    virtual bool keepEventInShadowDOM(Event*) OVERRIDE;
 };
 
 // ----------------------------