If the media controls are visible they should always grab clicks

Source/core/html/shadow/MediaControlElements.h

 /*
  * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 36 matching lines @@
 
 private:
     explicit MediaControlPanelElement(MediaControls&);
 
     virtual const AtomicString& shadowPseudoId() const OVERRIDE;
     virtual void defaultEventHandler(Event*) OVERRIDE;
 
     void startTimer();
     void stopTimer();
     void transitionTimerFired(Timer<MediaControlPanelElement>*);
+    virtual bool keepEventInShadowDOM(Event*) OVERRIDE;
 
     bool m_isDisplayed;
     bool m_opaque;
 
     Timer<MediaControlPanelElement> m_transitionTimer;
 };
 
 // ----------------------------
 
 class MediaControlPanelEnclosureElement FINAL : public MediaControlDivElement {
@@ skipping 54 matching lines @@
 public:
     static PassRefPtrWillBeRawPtr<MediaControlOverlayPlayButtonElement> create(MediaControls&);
 
     virtual void updateDisplayType() OVERRIDE;
 
 private:
     explicit MediaControlOverlayPlayButtonElement(MediaControls&);
 
     virtual const AtomicString& shadowPseudoId() const OVERRIDE;
     virtual void defaultEventHandler(Event*) OVERRIDE;
+    virtual bool keepEventInShadowDOM(Event*) OVERRIDE;

[acolwell GONE FROM CHROMIUM, 2014/07/29 16:23:26]

Perhaps I'm misunderstanding something. Why can't this be placed on
MediaControls instead since it is the parent of all the other controls? IIUC we
are just trying to prevent events from leaking outside of the all controls
right?

[aberent, 2014/07/31 10:52:47]

Unfortunately, to support the overlay play button, the MediaControls have the
same dimensions as the video; so placing this on the MediaControls would prevent
the video getting any clicks. We only want to capture clicks on the control bar,
not on other parts of the video.

 };
 
 // ----------------------------
 
 class MediaControlToggleClosedCaptionsButtonElement FINAL : public MediaControlInputElement {
 public:
     static PassRefPtrWillBeRawPtr<MediaControlToggleClosedCaptionsButtonElement> create(MediaControls&);
 
     virtual bool willRespondToMouseClickEvents() OVERRIDE { return true; }
 
@@ skipping 17 matching lines @@
     // FIXME: An "earliest possible position" will be needed once that concept
     // is supported by HTMLMediaElement, see https://crbug.com/137275
     void setPosition(double);
     void setDuration(double);
 
 private:
     explicit MediaControlTimelineElement(MediaControls&);
 
     virtual const AtomicString& shadowPseudoId() const OVERRIDE;
     virtual void defaultEventHandler(Event*) OVERRIDE;
+    virtual bool keepEventInShadowDOM(Event*) OVERRIDE;
 };
 
 // ----------------------------
 
 class MediaControlFullscreenButtonElement FINAL : public MediaControlInputElement {
 public:
     static PassRefPtrWillBeRawPtr<MediaControlFullscreenButtonElement> create(MediaControls&);
 
     virtual bool willRespondToMouseClickEvents() OVERRIDE { return true; }
 
@@ skipping 14 matching lines @@
 
     virtual bool willRespondToMouseMoveEvents() OVERRIDE;
     virtual bool willRespondToMouseClickEvents() OVERRIDE;
     void setVolume(double);
 
 private:
     explicit MediaControlVolumeSliderElement(MediaControls&);
 
     virtual const AtomicString& shadowPseudoId() const OVERRIDE;
     virtual void defaultEventHandler(Event*) OVERRIDE;
+    virtual bool keepEventInShadowDOM(Event*) OVERRIDE;
 };
 
 // ----------------------------
 
 class MediaControlTimeRemainingDisplayElement FINAL : public MediaControlTimeDisplayElement {
 public:
     static PassRefPtrWillBeRawPtr<MediaControlTimeRemainingDisplayElement> create(MediaControls&);
 
 private:
     explicit MediaControlTimeRemainingDisplayElement(MediaControls&);
@@ skipping 28 matching lines @@
     virtual RenderObject* createRenderer(RenderStyle*) OVERRIDE;
 
     IntRect m_videoDisplaySize;
     float m_fontSize;
 };
 
 
 } // namespace blink
 
 #endif // MediaControlElements_h