Source/core/events/EventTarget.h - Issue 406213002: If the media controls are visible they should always grab clicks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/events/EventTarget.h

Issue 406213002: If the media controls are visible they should always grab clicks (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Test added - now looking for LGTM or detailed comments. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/events/EventPath.cpp ('K') | « Source/core/events/EventPath.cpp ('k') | Source/core/html/shadow/MediaControlElements.h » ('j') | Source/core/html/shadow/MediaControlElements.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/events/EventTarget.h

diff --git a/Source/core/events/EventTarget.h b/Source/core/events/EventTarget.h

index 1e60b32ba223eda981d840caf7b50b73e5f578d8..9e68b06f25784fb1175b2ec54231bdb5f9fea2f3 100644

--- a/Source/core/events/EventTarget.h

+++ b/Source/core/events/EventTarget.h

@@ -139,6 +139,8 @@ public:

virtual void trace(Visitor*) { }

+ virtual bool keepEventInShadowDOM(Event*) { return false; };

protected:

EventTarget();

virtual ~EventTarget();