Issue 405973004: Optimize / clean up hasTagName() call sites

Issue 405973004: Optimize / clean up hasTagName() call sites (Closed)

Created:
6 years, 5 months ago by Inactive

Modified:
6 years, 5 months ago

Reviewers:
abarth-chromium

CC:
aboxhall, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, dglazkov+blink, dmazzoni, ed+blinkwatch_opera.com, rwlbuis, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Optimize / clean up hasTagName() call sites Optimize / clean up hasTagName() call sites so that they call when possible and in this order: - HTMLElement::hasTagName(HTMLQualifiedName) / SVGElement::hasTagName(SVGQualifiedName) - Node::hasTagName(HTMLQualifiedName) / Node::hasTagName(SVGQualifiedName) - Element::hasTagName(QualifiedName) Also use isHTML*Element() helpers in a couple of places to improve readability. This is a follow-up to: https://src.chromium.org/viewvc/blink?view=rev&revision=178540 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178581

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -51 lines)			Patch
M	Source/core/accessibility/AXNodeObject.cpp	View	4 chunks	+14 lines, -11 lines	0 comments	Download
M	Source/core/accessibility/AXRenderObject.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/accessibility/AXRenderObject.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/accessibility/AXTable.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/AffectedByFocusTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/EditingStyle.cpp	View	7 chunks	+12 lines, -12 lines	0 comments	Download
M	Source/core/editing/InsertListCommand.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/InsertListCommand.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/editing/MarkupAccumulator.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/ReplaceSelectionCommand.cpp	View	2 chunks	+10 lines, -9 lines	0 comments	Download
M	Source/core/html/HTMLTableElement.cpp	View	5 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/core/html/HTMLTableRowElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/405973004/1

6 years, 5 months ago (2014-07-21 19:56:48 UTC) #4

Message was sent while issue was closed.

Change committed as 178581

Expand Messages | Collapse Messages