Source/core/accessibility/AXTable.cpp - Issue 405973004: Optimize / clean up hasTagName() call sites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AXTable.cpp

Issue 405973004: Optimize / clean up hasTagName() call sites (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/accessibility/AXTable.cpp

diff --git a/Source/core/accessibility/AXTable.cpp b/Source/core/accessibility/AXTable.cpp

index 391cf459976dfca87cd77ba547c0d682c2c8160f..ba4b9e01c2069a5ceb15eeb2c35a3318cc74da59 100644

--- a/Source/core/accessibility/AXTable.cpp

+++ b/Source/core/accessibility/AXTable.cpp

@@ -144,7 +144,7 @@ bool AXTable::isDataTable() const

Element* rowElement = rows->item(rowIndex);

if (elementHasAriaRole(rowElement))

return false;

- if (rowElement->hasTagName(trTag)) {

+ if (isHTMLTableRowElement(*rowElement)) {

RefPtrWillBeRawPtr<HTMLCollection> cells = toHTMLTableRowElement(rowElement)->cells();

for (unsigned cellIndex = 0; cellIndex < cells->length(); ++cellIndex) {

if (elementHasAriaRole(cells->item(cellIndex)))