Source/core/editing/InsertListCommand.h - Issue 405973004: Optimize / clean up hasTagName() call sites

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/editing/InsertListCommand.h

Issue 405973004: Optimize / clean up hasTagName() call sites (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « Source/core/editing/EditingStyle.cpp ('k') | Source/core/editing/InsertListCommand.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006, 2008 Apple Inc. All rights reserved.	2 * Copyright (C) 2006, 2008 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
45	45

46 virtual void trace(Visitor*) OVERRIDE;	46 virtual void trace(Visitor*) OVERRIDE;

47	47

48 private:	48 private:

49 InsertListCommand(Document&, Type);	49 InsertListCommand(Document&, Type);

50	50

51 virtual void doApply() OVERRIDE;	51 virtual void doApply() OVERRIDE;

52 virtual EditAction editingAction() const OVERRIDE { return EditActionInsertL ist; }	52 virtual EditAction editingAction() const OVERRIDE { return EditActionInsertL ist; }

53	53

54 HTMLElement* fixOrphanedListChild(Node*);	54 HTMLElement* fixOrphanedListChild(Node*);

55 bool selectionHasListOfType(const VisibleSelection& selection, const Qualifi edName&);	55 bool selectionHasListOfType(const VisibleSelection&, const HTMLQualifiedName &);

56 PassRefPtrWillBeRawPtr<HTMLElement> mergeWithNeighboringLists(PassRefPtrWill BeRawPtr<HTMLElement>);	56 PassRefPtrWillBeRawPtr<HTMLElement> mergeWithNeighboringLists(PassRefPtrWill BeRawPtr<HTMLElement>);

57 void doApplyForSingleParagraph(bool forceCreateList, const HTMLQualifiedName &, Range& currentSelection);	57 void doApplyForSingleParagraph(bool forceCreateList, const HTMLQualifiedName &, Range& currentSelection);

58 void unlistifyParagraph(const VisiblePosition& originalStart, HTMLElement* l istNode, Node* listChildNode);	58 void unlistifyParagraph(const VisiblePosition& originalStart, HTMLElement* l istNode, Node* listChildNode);

59 PassRefPtrWillBeRawPtr<HTMLElement> listifyParagraph(const VisiblePosition& originalStart, const QualifiedName& listTag);	59 PassRefPtrWillBeRawPtr<HTMLElement> listifyParagraph(const VisiblePosition& originalStart, const HTMLQualifiedName& listTag);

60	60

61 RefPtrWillBeMember<HTMLElement> m_listElement;	61 RefPtrWillBeMember<HTMLElement> m_listElement;

62 Type m_type;	62 Type m_type;

63 };	63 };

64	64

65 } // namespace blink	65 } // namespace blink

66	66

67 #endif // InsertListCommand_h	67 #endif // InsertListCommand_h

OLD	NEW