Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 405813002: win32: Add a PlatformWindow implementation for Windows. (Closed)

Created:
6 years, 5 months ago by sadrul
Modified:
6 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

win32: Add a PlatformWindow implementation for Windows. Use this implementation for mojo native_viewport. It will also be used for aura WindowTreeHost in subsequent patches. BUG=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284752

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : fix-move-resize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -123 lines) Patch
M mojo/mojo_services.gypi View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_win.cc View 1 chunk +47 lines, -111 lines 0 comments Download
M ui/platform_window/platform_window.h View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M ui/platform_window/platform_window_delegate.h View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
A + ui/platform_window/win/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/platform_window/win/win_window.h View 1 2 3 4 1 chunk +77 lines, -0 lines 0 comments Download
A ui/platform_window/win/win_window.cc View 1 2 3 4 5 1 chunk +165 lines, -0 lines 0 comments Download
A + ui/platform_window/win/win_window.gyp View 1 2 1 chunk +7 lines, -9 lines 0 comments Download
A ui/platform_window/win/win_window_export.h View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sadrul
6 years, 5 months ago (2014-07-20 05:10:03 UTC) #1
Ben Goodger (Google)
sweet, thanks! lgtm
6 years, 5 months ago (2014-07-21 17:37:24 UTC) #2
sadrul
6 years, 5 months ago (2014-07-22 19:22:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #6 manually as r284752 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698